WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103291
PDFPlugin: Page scale factor should affect subframe PDFs
https://bugs.webkit.org/show_bug.cgi?id=103291
Summary
PDFPlugin: Page scale factor should affect subframe PDFs
Tim Horton
Reported
2012-11-26 13:55:58 PST
For subframe PDFs, hand PDFKit the pageScaleFactor for the parent page so it can scale its drawing appropriately. <
rdar://problem/12555249
>
Attachments
patch
(5.44 KB, patch)
2012-11-26 14:46 PST
,
Tim Horton
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2012-11-26 14:46:59 PST
Created
attachment 176078
[details]
patch
Darin Adler
Comment 2
2012-11-27 09:56:15 PST
Comment on
attachment 176078
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=176078&action=review
> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323 > + float newScaleFactor = controller()->contentsScaleFactor();
Is float the correct type here?
Tim Horton
Comment 3
2012-11-27 13:49:13 PST
(In reply to
comment #2
)
> (From update of
attachment 176078
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=176078&action=review
> > > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323 > > + float newScaleFactor = controller()->contentsScaleFactor(); > > Is float the correct type here?
Nope. Thanks, Darin!
Tim Horton
Comment 4
2012-11-27 14:46:48 PST
http://trac.webkit.org/changeset/135925
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug