Bug 103291 - PDFPlugin: Page scale factor should affect subframe PDFs
Summary: PDFPlugin: Page scale factor should affect subframe PDFs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-26 13:55 PST by Tim Horton
Modified: 2012-11-27 14:46 PST (History)
4 users (show)

See Also:

Attachments
patch (5.44 KB, patch)
2012-11-26 14:46 PST, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-11-26 13:55:58 PST 
For subframe PDFs, hand PDFKit the pageScaleFactor for the parent page so it can scale its drawing appropriately.

<rdar://problem/12555249>
Comment 1 Tim Horton 2012-11-26 14:46:59 PST 
Created attachment 176078 [details]
patch
Comment 2 Darin Adler 2012-11-27 09:56:15 PST 
Comment on attachment 176078 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176078&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323
> +    float newScaleFactor = controller()->contentsScaleFactor();

Is float the correct type here?
Comment 3 Tim Horton 2012-11-27 13:49:13 PST 
(In reply to comment #2)
> (From update of attachment 176078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176078&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323
> > +    float newScaleFactor = controller()->contentsScaleFactor();
> 
> Is float the correct type here?

Nope. Thanks, Darin!
Comment 4 Tim Horton 2012-11-27 14:46:48 PST 
http://trac.webkit.org/changeset/135925