Bug 103275 - Convert test fast/backgrounds/background-opaque-images-over-color.html to a ref test
Summary: Convert test fast/backgrounds/background-opaque-images-over-color.html to a r...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Novosad
Depends on: 103424
  Show dependency treegraph
Reported: 2012-11-26 10:56 PST by Justin Novosad
Modified: 2012-11-27 09:06 PST (History)
4 users (show)

See Also:

Patch (4.40 KB, patch)
2012-11-26 11:15 PST, Justin Novosad
no flags Details | Formatted Diff | Diff
Patch for landing (4.69 KB, patch)
2012-11-26 11:44 PST, Justin Novosad
no flags Details | Formatted Diff | Diff
Patch for landing (4.40 KB, patch)
2012-11-26 11:47 PST, Justin Novosad
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Novosad 2012-11-26 10:56:18 PST
Convert test fast/backgrounds/background-opaque-images-over-color to a ref test

Follow-up on post-commit feedback on https://bugs.webkit.org/show_bug.cgi?id=102557
Comment 1 Justin Novosad 2012-11-26 11:15:42 PST
Created attachment 176039 [details]
Comment 2 Simon Fraser (smfr) 2012-11-26 11:37:43 PST
Comment on attachment 176039 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=176039&action=review

> LayoutTests/ChangeLog:8
> +        Removing existing baselines, and adding an -expecte.html to make

Typo: -expecte.html
Comment 3 Justin Novosad 2012-11-26 11:44:10 PST
Created attachment 176041 [details]
Patch for landing
Comment 4 Justin Novosad 2012-11-26 11:45:32 PST
Comment on attachment 176041 [details]
Patch for landing

cq- -> svn/patch booboo
Comment 5 Justin Novosad 2012-11-26 11:47:19 PST
Created attachment 176042 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-11-26 11:49:06 PST
Comment on attachment 176042 [details]
Patch for landing

Rejecting attachment 176042 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 255 cwd: /mnt/git/webkit-commit-queue

Did not find end of header block corresponding to index path "LayoutTests/platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png". at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 840, <ARGV> line 85.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 255 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14989717
Comment 7 Justin Novosad 2012-11-27 06:59:09 PST
Cowboy landed to circumvent cq barfage around png deletions.

Comment 9 Justin Novosad 2012-11-27 08:53:27 PST
(In reply to comment #8)

> It fails everywhere:
It is already fixed with r135861
There was a typo in the baseline
Comment 11 Justin Novosad 2012-11-27 09:02:22 PST
> It still fails on Qt on r135862 - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r135862%20%2845465%29/fast/backgrounds/background-opaque-images-over-color-diffs.html
> and it still fails on Apple Mac on r135863 - http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20%28Tests%29/r135863%20%286600%29/fast/backgrounds/background-opaque-images-over-color-diffs.html

Looks like the new test uncovered a compositing bug in the Qt port.  The diff on the mac port looks like it is just numerical rounding issue in the blending arithmetic.  I think the correct course is to add TestExpectations and file new bugs.