Bug 103275 – Convert test fast/backgrounds/background-opaque-images-over-color.html to a ref test

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Justin Novosad]

Convert test fast/backgrounds/background-opaque-images-over-color to a ref test

Follow-up on post-commit feedback on https://bugs.webkit.org/show_bug.cgi?id=102557

[Justin Novosad]

Created attachment 176039 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 176039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176039&action=review

> LayoutTests/ChangeLog:8
> +        Removing existing baselines, and adding an -expecte.html to make

Typo: -expecte.html

[Justin Novosad]

Created attachment 176041 [details]
Patch for landing

[Justin Novosad]

Comment on attachment 176041 [details]
Patch for landing

cq- -> svn/patch booboo

[Justin Novosad]

Created attachment 176042 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 176042 [details]
Patch for landing

Rejecting attachment 176042 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 255 cwd: /mnt/git/webkit-commit-queue

Did not find end of header block corresponding to index path "LayoutTests/platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png". at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 840, <ARGV> line 85.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 255 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14989717

[Justin Novosad]

Cowboy landed to circumvent cq barfage around png deletions.

http://trac.webkit.org/changeset/135859

[Csaba Osztrogonác]

(In reply to comment #7)
> Cowboy landed to circumvent cq barfage around png deletions.
> 
> http://trac.webkit.org/changeset/135859

It fails everywhere:
EFL - http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release/r135860%20%287971%29/fast/backgrounds/background-opaque-images-over-color-diffs.html
Apple Mac - http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20%28Tests%29/r135863%20%286600%29/fast/backgrounds/background-opaque-images-over-color-diffs.html
Qt - http://build.webkit.org/results/Qt%20Linux%20Release/r135859%20%2854963%29/fast/backgrounds/background-opaque-images-over-color-diffs.html

[Justin Novosad]

(In reply to comment #8)

> It fails everywhere:
It is already fixed with r135861
There was a typo in the baseline

[Csaba Osztrogonác]

(In reply to comment #9)
> (In reply to comment #8)
> 
> > It fails everywhere:
> It is already fixed with r135861
> There was a typo in the baseline

It still fails on Qt on r135862 - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r135862%20%2845465%29/fast/backgrounds/background-opaque-images-over-color-diffs.html

and it still fails on Apple Mac on r135863 - http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20%28Tests%29/r135863%20%286600%29/fast/backgrounds/background-opaque-images-over-color-diffs.html

[Justin Novosad]

> It still fails on Qt on r135862 - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r135862%20%2845465%29/fast/backgrounds/background-opaque-images-over-color-diffs.html
> 
> and it still fails on Apple Mac on r135863 - http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20%28Tests%29/r135863%20%286600%29/fast/backgrounds/background-opaque-images-over-color-diffs.html

Looks like the new test uncovered a compositing bug in the Qt port.  The diff on the mac port looks like it is just numerical rounding issue in the blending arithmetic.  I think the correct course is to add TestExpectations and file new bugs.