Bug 103273 - [Cairo] Surface should not be destroyed before its usage
Summary: [Cairo] Surface should not be destroyed before its usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Brandao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 10:29 PST by Rafael Brandao
Modified: 2012-11-26 15:21 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2012-11-26 10:31 PST, Rafael Brandao 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Brandao 2012-11-26 10:29:03 PST 
[Cairo] Surface should not be destroyed before its usage
Comment 1 Rafael Brandao 2012-11-26 10:31:18 PST 
Created attachment 176029 [details]
Patch
Comment 2 Brent Fulgham 2012-11-26 10:53:29 PST 
Comment on attachment 176029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176029&action=review

Great catch. r=me.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:-363
> -    cairo_surface_destroy(surface);

Wow!  I'm surprised this ever worked.
Comment 3 Rafael Brandao 2012-11-26 10:54:38 PST 
Comment on attachment 176029 [details]
Patch

Me too. :-)
Comment 4 WebKit Review Bot 2012-11-26 11:12:48 PST 
Comment on attachment 176029 [details]
Patch

Clearing flags on attachment: 176029

Committed r135742: <http://trac.webkit.org/changeset/135742>
Comment 5 WebKit Review Bot 2012-11-26 11:12:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kenneth Rohde Christiansen 2012-11-26 15:17:18 PST 
Comment on attachment 176029 [details]
Patch

Nice
Comment 7 Kenneth Rohde Christiansen 2012-11-26 15:17:51 PST 
Btw, did this solve any reproducible bugs?
Comment 8 Rafael Brandao 2012-11-26 15:21:24 PST 
(In reply to comment #7)
> Btw, did this solve any reproducible bugs?

I wish, but I couldn't observe anything. I'm focusing on the scale < 1.0 bug right now and stumbled right into this.