Bug 103260 - [Qt] Implement the mimetype icon methods
Summary: [Qt] Implement the mimetype icon methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 08:32 PST by Allan Sandfeld Jensen
Modified: 2012-11-27 03:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2012-11-26 08:36 PST, Allan Sandfeld Jensen
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-26 08:32:45 PST
IconQt.cpp has an empty implementation of finding a icon for the given filenames. Using QMimeDatabase it should be simple now to lookup and return appropiate icons.
Comment 1 Allan Sandfeld Jensen 2012-11-26 08:36:30 PST
Created attachment 176007 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2012-11-26 08:38:31 PST
I think this will be tested indirectly by many of the tests using the file INPUT element.

To test manually, you can use bugs.webkit.org and see the icon when attaching files.
Comment 3 Allan Sandfeld Jensen 2012-11-27 03:16:38 PST
Committed r135842: <http://trac.webkit.org/changeset/135842>