Bug 103224 - [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
Summary: [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 01:20 PST by Chris Dumez
Modified: 2012-11-26 12:18 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.94 KB, patch)
2012-11-26 02:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-11-26 01:20:04 PST
There is currently no API in ewk_settings to enable / disable the HTML5 local storage functionality.
Comment 1 Chris Dumez 2012-11-26 02:52:04 PST
Created attachment 175953 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2012-11-26 02:59:31 PST
Comment on attachment 175953 [details]
Patch

looks good
Comment 3 Laszlo Gombos 2012-11-26 07:41:57 PST
Comment on attachment 175953 [details]
Patch

r=me.

Some settings (e.g. probably this one) can not be changed just any time in the life cycle of the view. If we could somehow capture that in the API documentation that would help (at least to note that the recommendation is to set the settings before issuing the load).

This is a generic comment not necessary specific to this  patch.
Comment 4 WebKit Review Bot 2012-11-26 07:43:57 PST
Comment on attachment 175953 [details]
Patch

Rejecting attachment 175953 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
hanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>

Full output: http://queues.webkit.org/results/14981709
Comment 5 Laszlo Gombos 2012-11-26 12:05:01 PST
Comment on attachment 175953 [details]
Patch

lets try again..
Comment 6 WebKit Review Bot 2012-11-26 12:18:22 PST
Comment on attachment 175953 [details]
Patch

Clearing flags on attachment: 175953

Committed r135752: <http://trac.webkit.org/changeset/135752>
Comment 7 WebKit Review Bot 2012-11-26 12:18:27 PST
All reviewed patches have been landed.  Closing bug.