Bug 103224 – [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

There is currently no API in ewk_settings to enable / disable the HTML5 local storage functionality.

[Chris Dumez]

Created attachment 175953 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 175953 [details]
Patch

looks good

[Laszlo Gombos]

Comment on attachment 175953 [details]
Patch

r=me.

Some settings (e.g. probably this one) can not be changed just any time in the life cycle of the view. If we could somehow capture that in the API documentation that would help (at least to note that the recommendation is to set the settings before issuing the load).

This is a generic comment not necessary specific to this  patch.

[WebKit Review Bot]

Comment on attachment 175953 [details]
Patch

Rejecting attachment 175953 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
hanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>

Full output: http://queues.webkit.org/results/14981709

[Laszlo Gombos]

Comment on attachment 175953 [details]
Patch

lets try again..

[WebKit Review Bot]

Comment on attachment 175953 [details]
Patch

Clearing flags on attachment: 175953

Committed r135752: <http://trac.webkit.org/changeset/135752>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.