RESOLVED FIXED 103222
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. 
https://bugs.webkit.org/show_bug.cgi?id=103222
Summary Web Inspector: object preview does not render node id, className; logs too ma...
Pavel Feldman
Reported 2012-11-26 00:59:10 PST
Downstream bug: http://code.google.com/p/chromium/issues/detail?id=162570
Attachments
Patch (16.09 KB, patch)
2012-11-26 01:10 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (23.14 KB, patch)
2012-11-26 02:12 PST, Pavel Feldman 		yurys: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-11-26 01:10:38 PST
Created attachment 175939 [details] Patch
Build Bot
Comment 2 2012-11-26 01:43:44 PST
Comment on attachment 175939 [details] Patch Attachment 175939 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15003033 New failing tests: inspector/console/command-line-api-inspect.html inspector/console/console-format-collections.html
Yury Semikhatsky
Comment 3 2012-11-26 02:01:39 PST
Comment on attachment 175939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175939&action=review > Source/WebCore/inspector/InspectorOverlayPage.html:91 > + /* Keep this in sync with view-source.css (.webkit-html-attribute-value) */ can we declare this style once and enumerate all selectors, like this: #node-id, .webkit-html-attribute-value, .node-id {...} ? > Source/WebCore/inspector/InspectorOverlayPage.html:349 > + document.getElementById("class-name").textContent = className || ""; className || "" -> className ?
Pavel Feldman
Comment 4 2012-11-26 02:12:20 PST
Created attachment 175945 [details] Patch
Build Bot
Comment 5 2012-11-26 03:10:50 PST
Comment on attachment 175945 [details] Patch Attachment 175945 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14984594 New failing tests: inspector/console/console-format-collections.html
Pavel Feldman
Comment 6 2012-11-26 06:02:36 PST
Committed r135712: <http://trac.webkit.org/changeset/135712>
Pavel Feldman
Comment 7 2012-11-26 07:19:26 PST
Committed r135720: <http://trac.webkit.org/changeset/135720>
Note You need to log in before you can comment on or make changes to this bug.