Bug 103190 - [BlackBerry] Find-on-page keeps stale pointer
Summary: [BlackBerry] Find-on-page keeps stale pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-24 15:53 PST by Andy Chen
Modified: 2012-11-24 20:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2012-11-24 17:12 PST, Andy Chen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Chen 2012-11-24 15:53:00 PST 
It keeps stale pointer of frame. If the frame is unloaded, searching on that frame would cause segmentation fault.
Comment 1 Andy Chen 2012-11-24 17:12:46 PST 
Created attachment 175869 [details]
Patch
Comment 2 Rob Buis 2012-11-24 17:19:21 PST 
Comment on attachment 175869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175869&action=review

LGTM.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:251
> +    for (size_t i = 0; i < m_deferredScopingWork.size(); i++) {

pre-increment is more efficient.
Comment 3 WebKit Review Bot 2012-11-24 19:03:36 PST 
Comment on attachment 175869 [details]
Patch

Rejecting attachment 175869 [details] from commit-queue.

New failing tests:
svg/W3C-SVG-1.1/animate-elem-78-t.svg
Full output: http://queues.webkit.org/results/14984154
Comment 4 WebKit Review Bot 2012-11-24 20:14:14 PST 
Comment on attachment 175869 [details]
Patch

Clearing flags on attachment: 175869

Committed r135664: <http://trac.webkit.org/changeset/135664>
Comment 5 WebKit Review Bot 2012-11-24 20:14:18 PST 
All reviewed patches have been landed.  Closing bug.