Bug 103189 - [EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
Summary: [EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 103186
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-24 14:45 PST by Chris Dumez
Modified: 2012-11-25 11:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2012-11-24 14:55 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2012-11-24 14:59 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-11-24 14:45:48 PST
ThemePartCacheEntry::reuse() does not currently check if the size and type changed before doing processing. This may lead to useless processing in case one of those (size or type) did not change.
Comment 1 Chris Dumez 2012-11-24 14:55:50 PST
Created attachment 175866 [details]
Patch
Comment 2 Chris Dumez 2012-11-24 14:59:10 PST
Created attachment 175867 [details]
Patch
Comment 3 Mikhail Pozdnyakov 2012-11-24 15:08:06 PST
Comment on attachment 175867 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2012-11-24 20:39:52 PST
Comment on attachment 175867 [details]
Patch

Rejecting attachment 175867 [details] from commit-queue.

New failing tests:
svg/W3C-SVG-1.1/animate-elem-78-t.svg
Full output: http://queues.webkit.org/results/14982191
Comment 5 Chris Dumez 2012-11-25 00:48:38 PST
Comment on attachment 175867 [details]
Patch

This patch cannot affect chromium so it must be a false warning. Requesting cq? again.
Comment 6 WebKit Review Bot 2012-11-25 11:19:53 PST
Comment on attachment 175867 [details]
Patch

Clearing flags on attachment: 175867

Committed r135673: <http://trac.webkit.org/changeset/135673>
Comment 7 WebKit Review Bot 2012-11-25 11:19:58 PST
All reviewed patches have been landed.  Closing bug.