Bug 103187 - [EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
Summary: [EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-24 13:32 PST by Mikhail Pozdnyakov
Modified: 2012-11-24 18:18 PST (History)
6 users (show)

See Also:


Attachments
patch (9.58 KB, patch)
2012-11-24 13:38 PST, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-11-24 13:32:40 PST
Currently the client has to pass "char" in DECLARE_EWK_VIEW_CALLBACK if s/he wants to have string (const char* actually) as callback parameter, has to pass 'Ewk_Error' if wants to have 'Ewk_Error*' but at the same time passes just 'void' if wants to have 'void' -- this is real mess which I cannot stand any more! Patch is coming.
Comment 1 Mikhail Pozdnyakov 2012-11-24 13:38:36 PST
Created attachment 175865 [details]
patch
Comment 2 Chris Dumez 2012-11-24 14:25:14 PST
Comment on attachment 175865 [details]
patch

LGTM. Much better indeed.
Comment 3 WebKit Review Bot 2012-11-24 18:18:53 PST
Comment on attachment 175865 [details]
patch

Clearing flags on attachment: 175865

Committed r135660: <http://trac.webkit.org/changeset/135660>
Comment 4 WebKit Review Bot 2012-11-24 18:18:57 PST
All reviewed patches have been landed.  Closing bug.