Bug 103143 - GraphicsSurface should only store its size in a single place.
Summary: GraphicsSurface should only store its size in a single place.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 07:46 PST by Zeno Albisser
Modified: 2012-11-26 04:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.61 KB, patch)
2012-11-23 07:55 PST, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Patch (12.96 KB, patch)
2012-11-24 07:36 PST, Zeno Albisser 		kenneth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-11-23 07:46:12 PST 
GraphicsSurface should only store its size in a single place.
Comment 1 Zeno Albisser 2012-11-23 07:55:00 PST 
Created attachment 175810 [details]
Patch
Comment 2 Zeno Albisser 2012-11-24 06:44:58 PST 
Sorry Kenneth, i messed up here.
There is something missing in this patch.

I need to add a ctor for GraphicsSurfacePrivate that takes a winId as an argument as well.
I'll upload an updated patch.
Comment 3 Kenneth Rohde Christiansen 2012-11-24 06:53:47 PST 
OK fine!
Comment 4 Zeno Albisser 2012-11-24 07:36:07 PST 
Created attachment 175857 [details]
Patch
Comment 5 Kenneth Rohde Christiansen 2012-11-24 07:52:12 PST 
Comment on attachment 175857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175857&action=review

> Source/WebCore/ChangeLog:25
> +            Retreive the size from GraphicsSurfacePrivate where necessary.

retrieve*

> Source/WebCore/ChangeLog:39
> +            Retreive the size from GraphicsSurfacePrivate where necessary.

retrieve*
Comment 6 Zeno Albisser 2012-11-26 04:33:08 PST 
Committed r135706: <http://trac.webkit.org/changeset/135706>