Bug 103140 – [chromium] Skip tests that will be broken by an upcoming V8 3.15.5 roll.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector (Deprecated)

[Ulan Degenbaev]

These two tests assume that Object.getOwnPropertyDescriptor on objects with interceptors doesn't return anything. This has been fixed in V8.

LayoutTests/inspector/console/command-line-api-inspect.html
LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html

We will submit updated test expectations after V8 roll.

[Pavel Feldman]

Could you paste the diff they produce?

[Ulan Degenbaev]

Created attachment 175803 [details]
Patch

[Ulan Degenbaev]

The diffs:

--- chromium/src/webkit/Debug/layout-test-results/inspector/console/command-line-api-inspect-expected.txt
+++ chromium/src/webkit/Debug/layout-test-results/inspector/console/command-line-api-inspect-actual.txt
@@ -28,12 +28,12 @@

 WebInspector.inspect called with: Storage
 WebInspector.inspect's hints are: ["domStorageId"]
-inspect(localStorage) = Storage {}
+inspect(localStorage) = Storage {auditsSidebarWidth: "200",
consoleHistory: "["inspect($('#p1'))","inspect(db)","inspect(db2)"]",
elementsSidebarWidth: "325", experiments: "{}", inspector: "Test of
local storage reveal in inspector"…}

 Running: testRevealSessionStorage


 WebInspector.inspect called with: Storage
 WebInspector.inspect's hints are: ["domStorageId"]
-inspect(sessionStorage) = Storage {}
+inspect(sessionStorage) = Storage {inspector: "Test of session
storage reveal in inspector"}


--- chromium/src/webkit/Debug/layout-test-results/inspector/runtime/runtime-localStorage-getProperties-expected.txt
+++ chromium/src/webkit/Debug/layout-test-results/inspector/runtime/runtime-localStorage-getProperties-actual.txt
@@ -1,12 +1,12 @@
 Tests RemoteObject.getProperties on localStorage object. 66215

 {
-    enumerable : false
+    enumerable : true
     name : "testProperty"
     value : {
         description : "testPropertyValue"
         type : "string"
     }
-    writable : false
+    writable : true
 }

[Pavel Feldman]

Comment on attachment 175803 [details]
Patch

We need to organize this better: once this patch lands, it'll close the bug it is referencing. The TestExpectations line should instead reference an opened bug.

[Ulan Degenbaev]

V8 roll seems to be sticking, I am going to upload CL that adjusts expectations, so there is no need to skip the tests: https://bugs.webkit.org/show_bug.cgi?id=103140.

[Timothy Hatcher]

Chromium and V8 have left the building. Won't fix.