Bug 10314 - WebUnarchivingState archivedResourceForURL: doesn't work
Summary: WebUnarchivingState archivedResourceForURL: doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Graham Dennis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-08 19:10 PDT by Graham Dennis
Modified: 2006-08-15 08:08 PDT (History)
0 users

See Also:

Attachments
patch (1.29 KB, patch)
2006-08-08 19:20 PDT, Graham Dennis 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Dennis 2006-08-08 19:10:57 PDT 
This method tries to get the object from the archivedResources dictionary with a key of (NSURL *)URL, however, objects are put into that dictionary with (NSString *)[URL _web_originalDataAsString]. This prevents the data for applewebdata:// URL's (e.g. for pasted images) to be fetched correctly for WebCore's cache.

Patch forthcoming.
Comment 1 Graham Dennis 2006-08-08 19:20:51 PDT 
Created attachment 9951 [details]
patch

Patch.
Comment 2 Darin Adler 2006-08-10 16:57:28 PDT 
Comment on attachment 9951 [details]
patch

Clearly correct. Great change.

Can we make a test for this?
Comment 3 Graham Dennis 2006-08-10 17:03:53 PDT 
I forgot to mention the lack of a test when I submitted the patch. I'm not sure how to create a testcase for this... hints?
Comment 4 Darin Adler 2006-08-15 08:06:48 PDT 
(In reply to comment #3)
> I forgot to mention the lack of a test when I submitted the patch. I'm not sure
> how to create a testcase for this... hints?

Using the new code that allows you to make Objective-C calls from JavaScript DumpRenderTree tests I imagine you could call this method. Beyond that, I'm not sure of the details.
Comment 5 Darin Adler 2006-08-15 08:08:00 PDT 
Committed revision 15878.