RESOLVED FIXED 103125
tst_qwebpage fails after QMimeDatabase patch 
https://bugs.webkit.org/show_bug.cgi?id=103125
Summary tst_qwebpage fails after QMimeDatabase patch
Allan Sandfeld Jensen
Reported 2012-11-23 04:23:46 PST
The API test tst_qwebpage relies on a static translation of extensions to mimetypes and fails after QtWebKit has been updated to use the QMimeDatabase, because one of the types has a different translation in QMimeDatabase.
Attachments
Patch (3.47 KB, patch)
2012-11-23 04:29 PST, Allan Sandfeld Jensen 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-11-23 04:29:05 PST
Created attachment 175777 [details] Patch
WebKit Review Bot
Comment 2 2012-11-23 04:33:31 PST
Attachment 175777 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Hausmann
Comment 3 2012-11-23 05:20:50 PST
Comment on attachment 175777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175777&action=review >> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992 >> + contentTypes << "application/x-mimearchive"; > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] This is indeed a three character indent instead of four. Please fix before landing :)
Allan Sandfeld Jensen
Comment 4 2012-11-23 06:06:23 PST
Committed r135602: <http://trac.webkit.org/changeset/135602>
Note You need to log in before you can comment on or make changes to this bug.