Bug 103125 - tst_qwebpage fails after QMimeDatabase patch
Summary: tst_qwebpage fails after QMimeDatabase patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 04:23 PST by Allan Sandfeld Jensen
Modified: 2012-11-23 06:06 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2012-11-23 04:29 PST, Allan Sandfeld Jensen
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-23 04:23:46 PST
The API test tst_qwebpage relies on a static translation of extensions to mimetypes and fails after QtWebKit has been updated to use the QMimeDatabase, because one of the types has a different translation in QMimeDatabase.
Comment 1 Allan Sandfeld Jensen 2012-11-23 04:29:05 PST
Created attachment 175777 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-23 04:33:31 PST
Attachment 175777 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2012-11-23 05:20:50 PST
Comment on attachment 175777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175777&action=review

>> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992
>> +   contentTypes << "application/x-mimearchive";
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

This is indeed a three character indent instead of four. Please fix before landing :)
Comment 4 Allan Sandfeld Jensen 2012-11-23 06:06:23 PST
Committed r135602: <http://trac.webkit.org/changeset/135602>