There are many entries for gtk, cocoa and other platforms that are later filtered out but they cause chromium compilation errors on changes in those platforms like http://trac.webkit.org/changeset/135255. There is no need to reference these files from WebCore.gypi
Created attachment 175775 [details] Patch
Comment on attachment 175775 [details] Patch "I regret nothing"?
Comment on attachment 175775 [details] Patch Clearing flags on attachment: 175775 Committed r135592: <http://trac.webkit.org/changeset/135592>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 103126
> There is no need to reference these files from WebCore.gypi I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this.
(In reply to comment #6) > > There is no need to reference these files from WebCore.gypi > > I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this. Yeah, as build bots showed Chromium depends on some of the win and mac files. But the rest still can be removed.
This is not what I said - it was not about not breaking the build, but about having the files in project for humans to easily access them. I don't have any opinion on whether it's desirable or not.
> I don't have any opinion on whether it's desirable or not. IMHO, the cost of having the Windows build mysteriously break when a non-Chromium file is renamed is greater than any benefit folks get by having these files listed in the IDE.
Created attachment 195073 [details] Patch
Committed r146874: <http://trac.webkit.org/changeset/146874>