Bug 103123 - [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
Summary: [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in Tes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on: 103173
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-23 04:07 PST by Sudarsana Nagineni (babu)
Modified: 2012-11-28 08:06 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2012-11-23 04:38 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2012-11-23 04:51 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch V3 (2.04 KB, patch)
2012-11-26 09:04 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-11-23 04:07:06 PST 
Add support for PlatformWebView::simulateSpacebarKeyPress() and enable WebKit2 unit test that uses it.
Comment 1 Sudarsana Nagineni (babu) 2012-11-23 04:38:31 PST 
Created attachment 175780 [details]
Patch
Comment 2 Sudarsana Nagineni (babu) 2012-11-23 04:51:25 PST 
Created attachment 175782 [details]
Patch

Updated skip list.
Comment 3 Chris Dumez 2012-11-23 04:54:42 PST 
Comment on attachment 175782 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-11-23 05:38:47 PST 
Comment on attachment 175782 [details]
Patch

Clearing flags on attachment: 175782

Committed r135600: <http://trac.webkit.org/changeset/135600>
Comment 5 WebKit Review Bot 2012-11-23 05:38:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-11-24 02:46:21 PST 
Re-opened since this is blocked by bug 103173
Comment 7 Sudarsana Nagineni (babu) 2012-11-26 09:03:06 PST 
API test is passing on local machine, but it's failing on our bots due to the timing issue. Increasing the responsivenessTimeout helps in passing the test on bots also, but I think we don't need that change since the timing issue is only on our bots.

Other API test(MouseMoveAfterCrash) is dependent on this functionality (bug #103252), so I am going to update the patch without unskipping the ResponsivenessTimerDoesntFireEarly test for now.
Comment 8 Sudarsana Nagineni (babu) 2012-11-26 09:04:23 PST 
Created attachment 176013 [details]
Patch V3
Comment 9 Laszlo Gombos 2012-11-28 07:31:50 PST 
Comment on attachment 176013 [details]
Patch V3

r=me.
Comment 10 WebKit Review Bot 2012-11-28 08:06:48 PST 
Comment on attachment 176013 [details]
Patch V3

Clearing flags on attachment: 176013

Committed r136011: <http://trac.webkit.org/changeset/136011>
Comment 11 WebKit Review Bot 2012-11-28 08:06:54 PST 
All reviewed patches have been landed.  Closing bug.