PR:237072
Created attachment 175720 [details] Patch
Comment on attachment 175720 [details] Patch LGTM
Comment on attachment 175720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review I think it could have a comment on that of the changed block. > Source/WebKit/blackberry/Api/WebPage.cpp:3467 > + bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished; nit: is the namespace needed? > Source/WebKit/blackberry/Api/WebPage.cpp:3472 > + if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished) ditto
(In reply to comment #3) > (From update of attachment 175720 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review > > I think it could have a comment on that of the changed block. > > > Source/WebKit/blackberry/Api/WebPage.cpp:3467 > > + bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished; > > nit: is the namespace needed? > > > Source/WebKit/blackberry/Api/WebPage.cpp:3472 > > + if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished) > > ditto Nice catch, thanks Antonio! I will update these and push directly.
Committed r135615: <http://trac.webkit.org/changeset/135615>