Bug 103098 - [BlackBerry] Meta viewport can't be changed dynamically
Summary: [BlackBerry] Meta viewport can't be changed dynamically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 17:45 PST by Jacky Jiang
Modified: 2012-11-23 08:32 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2012-11-22 18:08 PST, Jacky Jiang
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2012-11-22 17:45:01 PST
PR:237072
Comment 1 Jacky Jiang 2012-11-22 18:08:22 PST
Created attachment 175720 [details]
Patch
Comment 2 Rob Buis 2012-11-22 19:59:35 PST
Comment on attachment 175720 [details]
Patch

LGTM
Comment 3 Antonio Gomes 2012-11-23 04:36:03 PST
Comment on attachment 175720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review

I think it could have a comment on that of the changed block.

> Source/WebKit/blackberry/Api/WebPage.cpp:3467
> +    bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished;

nit: is the namespace needed?

> Source/WebKit/blackberry/Api/WebPage.cpp:3472
> +    if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished)

ditto
Comment 4 Jacky Jiang 2012-11-23 07:49:15 PST
(In reply to comment #3)
> (From update of attachment 175720 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review
> 
> I think it could have a comment on that of the changed block.
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:3467
> > +    bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished;
> 
> nit: is the namespace needed?
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:3472
> > +    if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished)
> 
> ditto

Nice catch,  thanks Antonio! I will update these and push directly.
Comment 5 Jacky Jiang 2012-11-23 08:32:54 PST
Committed r135615: <http://trac.webkit.org/changeset/135615>