Bug 103088 - Remove SVGShadowText
Summary: Remove SVGShadowText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 13:02 PST by Antti Koivisto
Modified: 2012-11-22 14:48 PST (History)
7 users (show)

See Also:

Attachments
patch (5.50 KB, patch)
2012-11-22 14:03 PST, Antti Koivisto 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-11-22 13:02:46 PST 
SVGShadowText subclass has little functionality beyond the plain Text. Remove it for simplicity.
Comment 1 Antti Koivisto 2012-11-22 14:03:17 PST 
Created attachment 175709 [details]
patch
Comment 2 Ryosuke Niwa 2012-11-22 14:17:29 PST 
Comment on attachment 175709 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175709&action=review

> Source/WebCore/dom/Text.cpp:242
> +static bool isSVGShadowText(Text* text)

I would add inline if I were you.

> Source/WebCore/dom/Text.cpp:248
> +static bool isSVGText(Text* text)

Ditto.

> Source/WebCore/svg/SVGTRefElement.cpp:162
>          root->firstChild()->setTextContent(textContent, ASSERT_NO_EXCEPTION);

We should probably assert that firstChild is a Text node.
Comment 3 Antti Koivisto 2012-11-22 14:48:25 PST 
http://trac.webkit.org/changeset/135544