WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103085
Get rid of HTMLCollectionCacheBase
https://bugs.webkit.org/show_bug.cgi?id=103085
Summary
Get rid of HTMLCollectionCacheBase
Ryosuke Niwa
Reported
2012-11-22 11:50:14 PST
HTMLCollectionCacheBase was introduced in
http://trac.webkit.org/changeset/121580
in order to share more code between HTMLCollection and DynamicNodeList implementations. Now that we've merged two classes, this class is nothing but a hallow shell. Merge it into HTMLCollection.
Attachments
cleanup
(10.57 KB, patch)
2012-11-22 12:00 PST
,
Ryosuke Niwa
sam
: review+
eflews.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-11-22 12:00:10 PST
Created
attachment 175698
[details]
cleanup
Ryosuke Niwa
Comment 2
2012-11-22 12:04:11 PST
Comment on
attachment 175698
[details]
cleanup Thanks fort the timely review!
EFL EWS Bot
Comment 3
2012-11-22 12:06:06 PST
Comment on
attachment 175698
[details]
cleanup
Attachment 175698
[details]
did not pass efl-ews (efl): Output:
http://queues.webkit.org/results/14966446
Ryosuke Niwa
Comment 4
2012-11-22 12:07:01 PST
Committed
r135534
: <
http://trac.webkit.org/changeset/135534
>
Ryosuke Niwa
Comment 5
2012-11-22 12:20:13 PST
Build fix landed in
http://trac.webkit.org/changeset/135535
.
Eric Seidel (no email)
Comment 6
2012-11-23 06:57:48 PST
Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug