Bug 103082 - [Chromium] Shared graphics context should only pushGroupMarker() once
Summary: [Chromium] Shared graphics context should only pushGroupMarker() once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 10:03 PST by Stephen White
Modified: 2012-11-26 20:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.98 KB, patch)
2012-11-22 10:06 PST, Stephen White
no flags Details | Formatted Diff | Diff
Patch for landing (2.96 KB, patch)
2012-11-26 17:25 PST, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-11-22 10:03:05 PST
[Chromium] Shared graphics context should only pushGroupMarker() once
Comment 1 Stephen White 2012-11-22 10:06:10 PST
Created attachment 175691 [details]
Patch
Comment 2 James Robinson 2012-11-25 21:45:28 PST
Comment on attachment 175691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review

> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56
> +            m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext");

this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas.
Comment 3 Stephen White 2012-11-26 16:15:10 PST
Comment on attachment 175691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review

>> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56
>> +            m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext");
> 
> this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas.

Yeah, I was thinking of renaming this "SharedGraphicsContext" or something.  WDYT?
Comment 4 James Robinson 2012-11-26 16:23:42 PST
SGTM!
Comment 5 Stephen White 2012-11-26 17:25:35 PST
Created attachment 176124 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-11-26 20:10:33 PST
Comment on attachment 176124 [details]
Patch for landing

Clearing flags on attachment: 176124

Committed r135809: <http://trac.webkit.org/changeset/135809>
Comment 7 WebKit Review Bot 2012-11-26 20:10:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Gregg Tavares 2012-11-26 20:15:00 PST
If that's that case can't you move the pushGroupEXT to the code that's creating the SharedGraphicsContext? The whole point of this is so you, at a glance from the logs, tell which part of the code is generating errors.

If SharedGraphicsContext is used by more than one thing each of those things should be calling pushGroupEXT so we can tell them apart