Bug 103082 – [Chromium] Shared graphics context should only pushGroupMarker() once

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephen White]

[Chromium] Shared graphics context should only pushGroupMarker() once

[Stephen White]

Created attachment 175691 [details]
Patch

[James Robinson]

Comment on attachment 175691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review

> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56
> +            m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext");

this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas.

[Stephen White]

Comment on attachment 175691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review

>> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56
>> +            m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext");
> 
> this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas.

Yeah, I was thinking of renaming this "SharedGraphicsContext" or something.  WDYT?

[James Robinson]

SGTM!

[Stephen White]

Created attachment 176124 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 176124 [details]
Patch for landing

Clearing flags on attachment: 176124

Committed r135809: <http://trac.webkit.org/changeset/135809>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Gregg Tavares]

If that's that case can't you move the pushGroupEXT to the code that's creating the SharedGraphicsContext? The whole point of this is so you, at a glance from the logs, tell which part of the code is generating errors.

If SharedGraphicsContext is used by more than one thing each of those things should be calling pushGroupEXT so we can tell them apart