Bug 103066 - [V8] fix DOMWrapperWorld destructor
Summary: [V8] fix DOMWrapperWorld destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 06:37 PST by Dan Carney
Modified: 2012-11-22 14:56 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2012-11-22 06:39 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2012-11-22 06:37:00 PST 
[V8] fix DOMWrapperWorld destructor
Comment 1 Dan Carney 2012-11-22 06:39:51 PST 
Created attachment 175664 [details]
Patch
Comment 2 jochen 2012-11-22 06:51:28 PST 
Comment on attachment 175664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175664&action=review

> Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:85
> +    ASSERT(!isMainWorld());

why is the assert and the if in the next line not using the same condition?
Comment 3 Dan Carney 2012-11-22 06:55:08 PST 
Comment on attachment 175664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175664&action=review

>> Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:85
>> +    ASSERT(!isMainWorld());
> 
> why is the assert and the if in the next line not using the same condition?

there is a third type of world - uninitialized, which is the target of the return statement
Comment 4 WebKit Review Bot 2012-11-22 14:56:17 PST 
Comment on attachment 175664 [details]
Patch

Clearing flags on attachment: 175664

Committed r135545: <http://trac.webkit.org/changeset/135545>
Comment 5 WebKit Review Bot 2012-11-22 14:56:20 PST 
All reviewed patches have been landed.  Closing bug.