Bug 103065 - [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
Summary: [Chromium] Return an accurate exit code when running Android suites, and wait...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 100100
  Show dependency tree / graph
 
Reported: 2012-11-22 06:21 PST by Peter Beverloo
Modified: 2012-11-22 18:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2012-11-22 06:24 PST, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Patch (4.58 KB, patch)
2012-11-22 10:32 PST, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Patch for landing (4.58 KB, patch)
2012-11-22 10:33 PST, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-11-22 06:21:38 PST 
[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
Comment 1 Peter Beverloo 2012-11-22 06:24:04 PST 
Created attachment 175659 [details]
Patch
Comment 2 Dirk Pranke 2012-11-22 10:29:53 PST 
Comment on attachment 175659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175659&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:435
> +            self._log_error('Unrecorgnized output from adb root: %s' % output)

typo: "Unrecorgnized" :).
Comment 3 Peter Beverloo 2012-11-22 10:32:59 PST 
Created attachment 175693 [details]
Patch
Comment 4 Peter Beverloo 2012-11-22 10:33:46 PST 
Created attachment 175694 [details]
Patch for landing
Comment 5 Peter Beverloo 2012-11-22 10:34:36 PST 
Comment on attachment 175694 [details]
Patch for landing

On Thanksgiving :-). Thank you very much for the review!

The typo has been fixed.
Comment 6 WebKit Review Bot 2012-11-22 18:39:37 PST 
Comment on attachment 175694 [details]
Patch for landing

Clearing flags on attachment: 175694

Committed r135552: <http://trac.webkit.org/changeset/135552>
Comment 7 WebKit Review Bot 2012-11-22 18:39:40 PST 
All reviewed patches have been landed.  Closing bug.