Bug 103061 - [V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
Summary: [V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 05:42 PST by Kentaro Hara
Modified: 2012-11-25 16:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.64 KB, patch)
2012-11-22 05:55 PST, Kentaro Hara 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-22 05:42:50 PST 
[V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
Comment 1 Kentaro Hara 2012-11-22 05:55:23 PST 
Created attachment 175655 [details]
Patch
Comment 2 Adam Barth 2012-11-22 22:52:29 PST 
Comment on attachment 175655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175655&action=review

> Source/WebCore/bindings/v8/V8Initializer.cpp:158
> +void V8Initializer::initializeWorkerIfNeeded()

Why is this "if needed"?  It seems like it always does the initialization.

> Source/WebCore/bindings/v8/V8Initializer.h:37
> +    static const int kWorkerMaxStackSize = 500 * 1024;

Why not just make this a static constant in V8Initializer.cpp ?
Comment 3 Kentaro Hara 2012-11-25 16:22:12 PST 
Committed r135674: <http://trac.webkit.org/changeset/135674>