Bug 103059 - Web Inspector: [REGRESSION] [Styles] Rule disappears if edited selector does not affect selected node
Summary: Web Inspector: [REGRESSION] [Styles] Rule disappears if edited selector does ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 05:34 PST by Alexander Pavlov (apavlov)
Modified: 2012-12-04 01:19 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.40 KB, patch)
2012-11-28 23:56 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2012-11-30 01:29 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (9.45 KB, patch)
2012-12-03 01:55 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (9.45 KB, patch)
2012-12-03 04:45 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (9.72 KB, patch)
2012-12-03 04:50 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-11-22 05:34:39 PST 
Such rules should get dimmed instead.
Comment 1 Alexander Pavlov (apavlov) 2012-11-28 23:56:28 PST 
Created attachment 176660 [details]
Patch
Comment 2 Pavel Feldman 2012-11-29 14:14:06 PST 
Comment on attachment 176660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176660&action=review

Having a dedicated test case for this would be great.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1317
> +        // This gets deleted in this._moveEditorFromSelector(), which is called both on success and failure.

_moveEditorFromSelector is called from many other places too.
Comment 3 Alexander Pavlov (apavlov) 2012-11-30 01:29:49 PST 
Created attachment 176921 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2012-12-03 01:55:57 PST 
Created attachment 177210 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2012-12-03 04:45:34 PST 
Created attachment 177230 [details]
Patch
Comment 6 Alexander Pavlov (apavlov) 2012-12-03 04:50:53 PST 
Created attachment 177231 [details]
Patch
Comment 7 Alexander Pavlov (apavlov) 2012-12-04 01:19:19 PST 
Committed r136488: <http://trac.webkit.org/changeset/136488>