RESOLVED FIXED 103057
[V8] Make worker context prototype chain match other browsers 
https://bugs.webkit.org/show_bug.cgi?id=103057
Summary [V8] Make worker context prototype chain match other browsers
Dan Carney
Reported 2012-11-22 05:06:49 PST
[V8] Make worker context prototype chain match other browsers
Attachments
Patch (1.58 KB, patch)
2012-11-22 05:10 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2012-11-22 07:49 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2012-11-22 05:10:09 PST
Created attachment 175650 [details] Patch
Dan Carney
Comment 2 2012-11-22 05:21:13 PST
This is required in advance of the v8 patch correctly throwing TypeErrors: https://codereview.chromium.org/11415046/
Dan Carney
Comment 3 2012-11-22 07:49:03 PST
Created attachment 175674 [details] Patch
Dan Carney
Comment 4 2012-11-22 07:50:46 PST
I would have added a test for this, but the v8 patch would cause all worker tests to fail without this patch, so it's covered.
Adam Barth
Comment 5 2012-11-22 22:55:48 PST
Comment on attachment 175674 [details] Patch OK. I'm not sure why we have an extra object for these worker contexts... Maybe to let global variables shadow own properties? In any case, I'm certainly willing to believe we should hide one level of prototype.
WebKit Review Bot
Comment 6 2012-11-22 23:33:30 PST
Comment on attachment 175674 [details] Patch Clearing flags on attachment: 175674 Committed r135560: <http://trac.webkit.org/changeset/135560>
WebKit Review Bot
Comment 7 2012-11-22 23:33:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.