Bug 103055 - [WK2][EFL] No need to remove surface before replacing
Summary: [WK2][EFL] No need to remove surface before replacing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 04:48 PST by Kenneth Rohde Christiansen
Modified: 2012-11-22 05:54 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2012-11-22 04:50 PST, Kenneth Rohde Christiansen 		hausmann: review+
Details | Formatted Diff | Diff
Image of resizing issue before patch (51.60 KB, image/png)
2012-11-22 04:52 PST, Kenneth Rohde Christiansen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-11-22 04:48:54 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2012-11-22 04:50:14 PST 
Created attachment 175648 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-22 04:52:45 PST 
Created attachment 175649 [details]
Image of resizing issue before patch
Comment 3 Kenneth Rohde Christiansen 2012-11-22 05:04:04 PST 
You will notice that on resize we flicker and there is at least one frame with the old size.
Comment 4 Mikhail Pozdnyakov 2012-11-22 05:15:17 PST 
[WK2] tag is missing in bug title.
Comment 5 Mikhail Pozdnyakov 2012-11-22 05:16:00 PST 
Comment on attachment 175648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175648&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:391
>              impl->createGLSurface(IntSize(width, height));

think it's better to rename this to resizeGLSurface
Comment 6 Chris Dumez 2012-11-22 05:18:40 PST 
Comment on attachment 175648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175648&action=review

LGTM.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:391
>>              impl->createGLSurface(IntSize(width, height));
> 
> think it's better to rename this to resizeGLSurface

No, I think the name is right. It is not technically resizing, it is creating a new surface with the new size. The previous surface is destroyed if existing.
Comment 7 Simon Hausmann 2012-11-22 05:49:20 PST 
Comment on attachment 175648 [details]
Patch

rs=me
Comment 8 Kenneth Rohde Christiansen 2012-11-22 05:54:26 PST 
Landed in 135514