Bug 103046 – [TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dongseong Hwang]

It is a preparation patch for Threaded Coordinated Graphics on WK1.

We want to make TextureMapperLayer into an actor model. After making an actor
model, GraphicsLayerTextureMapper and LayerTreeRenderer will communicate with
TextureMapperLayer using message passing. In the first step, we want to hide
GraphicsLayerTextureMapper from TextureMapperLayer.

There are 2 kinds of dependencies of TextureMapperLayer in GraphicsLayerTextureMapper.
1. To query layer states
2. To paint layer contents

In this patch, we removed the second dependency. Currently, TextureMapperLayer
requests painting contents to GraphicsLayerTextureMapper in WK1 while
Coordinated Graphics prepares the contents in LayerTreeRenderer. This patch
makes WK1 prepare the contents in GraphicsLayerTextureMapper like
LayerTreeRenderer.

We will remove the first dependency in a follow-up patch.

[Dongseong Hwang]

Created attachment 175636 [details]
Patch

[EFL EWS Bot]

Comment on attachment 175636 [details]
Patch

Attachment 175636 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14966333

[Noam Rosenthal]

Comment on attachment 175636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175636&action=review

Looks really good! Seems like it's missing some Timer.h includes though :)

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:57
> +    , m_shouldManageBackingStore(true)

m_hasOwnBackingStore

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475
> +

Empty line

[Dongseong Hwang]

(In reply to comment #3)
> (From update of attachment 175636 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175636&action=review
> 
> Looks really good! Seems like it's missing some Timer.h includes though :)

Thanks for review! I just do as you said :) 
GraphicsLayerTextureMapper absolutely needs Timer.h, but it's interesting how only qt can build without Timer.h.

> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:57
> > +    , m_shouldManageBackingStore(true)
> 
> m_hasOwnBackingStore

Done 

> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475
> > +
> 
> Empty line

Done

[Dongseong Hwang]

Created attachment 175715 [details]
Patch

[EFL EWS Bot]

Comment on attachment 175715 [details]
Patch

Attachment 175715 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14964571

[Dongseong Hwang]

Created attachment 175722 [details]
Patch

[EFL EWS Bot]

Comment on attachment 175722 [details]
Patch

Attachment 175722 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14967551

[Dongseong Hwang]

Created attachment 175724 [details]
Patch

[Dongseong Hwang]

fixed gtk and efl build fails.

[WebKit Review Bot]

Comment on attachment 175724 [details]
Patch

Clearing flags on attachment: 175724

Committed r135620: <http://trac.webkit.org/changeset/135620>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dongseong Hwang]

This bug causes Assertion fail. I'm sorry.

I'll file Bug 103171.