Bug 103018 – Correct input[type=number] value sanitization for user-input

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

1. Open a page with input[type=number]
2. Type "-1" into the number field
3. Additionally type "abc" into the number field

Expected result:
 Because the typed string is "-1abc" and it's not a valid number, HTMLInputElement::value should have sanitized value, "".

Actual result:
  HTMLInputElement::value is "-1".

Note: Opera's behavior is the "Expected result".

[Kent Tamura]

Created attachment 175587 [details]
Patch

[Early Warning System Bot]

Comment on attachment 175587 [details]
Patch

Attachment 175587 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14950260

[Kent Tamura]

Created attachment 175588 [details]
Patch 2

[Kentaro Hara]

Comment on attachment 175588 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=175588&action=review

Looks OK.

> Source/WebCore/ChangeLog:10
> +        sanitization algorithm defined by the HTML standard, and Opera's

You can add the link to the spec in ChangeLog.

[Kent Tamura]

Created attachment 175602 [details]
Patch 3

[Kent Tamura]

Thank you for the review.

I updated ChangeLog, and revised the patch because I found HTMLInputElement::isAcceptableValue and InputType::isAcceptableValue were unnecessary any more.

[WebKit Review Bot]

Comment on attachment 175602 [details]
Patch 3

Attachment 175602 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14965574

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[WebKit Review Bot]

Comment on attachment 175602 [details]
Patch 3

Clearing flags on attachment: 175602

Committed r135598: <http://trac.webkit.org/changeset/135598>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.