Bug 103014 - Move URL-checking code into Frame
Summary: Move URL-checking code into Frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 20:37 PST by Cosmin Truta
Modified: 2012-11-22 03:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.06 KB, patch)
2012-11-21 20:49 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2012-11-21 20:37:12 PST
The common code logic of HTMLFrameElementBase::isURLAllowed and HTMLPlugInImageElement::allowedToLoadFrameURL can be moved into a single place. I think the best candidate is a new method named Frame::isURLAllowed.
Comment 1 Cosmin Truta 2012-11-21 20:49:57 PST
Created attachment 175579 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-22 03:59:49 PST
Comment on attachment 175579 [details]
Patch

Clearing flags on attachment: 175579

Committed r135503: <http://trac.webkit.org/changeset/135503>
Comment 3 WebKit Review Bot 2012-11-22 03:59:52 PST
All reviewed patches have been landed.  Closing bug.