Bug 103011 - listMarkerText() should create 8 bit strings when possible
Summary: listMarkerText() should create 8 bit strings when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 20:12 PST by Michael Saboff
Modified: 2012-11-23 21:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2012-11-21 20:23 PST, Michael Saboff 		fpizlo: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch ith Speculative EFL build fix (9.47 KB, patch)
2012-11-21 21:44 PST, Michael Saboff 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch with speculative build fix for GTK and EFL (9.61 KB, patch)
2012-11-22 10:22 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-11-21 20:12:32 PST 
listMarkerText() always creates and returns a 16 bit string.  Most common marker types can represented by an 8 bit string.
Comment 1 Michael Saboff 2012-11-21 20:23:22 PST 
Created attachment 175575 [details]
Patch
Comment 2 EFL EWS Bot 2012-11-21 21:23:19 PST 
Comment on attachment 175575 [details]
Patch

Attachment 175575 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14969210
Comment 3 Michael Saboff 2012-11-21 21:44:36 PST 
Created attachment 175585 [details]
Patch ith Speculative EFL build fix
Comment 4 EFL EWS Bot 2012-11-22 00:06:05 PST 
Comment on attachment 175585 [details]
Patch ith Speculative EFL build fix

Attachment 175585 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14959241
Comment 5 Eric Seidel (no email) 2012-11-22 00:07:59 PST 
LGTM.
Comment 6 kov's GTK+ EWS bot 2012-11-22 01:23:24 PST 
Comment on attachment 175585 [details]
Patch ith Speculative EFL build fix

Attachment 175585 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14879872
Comment 7 Michael Saboff 2012-11-22 10:22:40 PST 
Created attachment 175692 [details]
Patch with speculative build fix for GTK and EFL

Added a typedef to work around what appears to be a compiler defect taking the sizeof() a argument to a templates function.
Comment 8 Michael Saboff 2012-11-23 21:19:16 PST 
Committed r135641: <http://trac.webkit.org/changeset/135641>