Add setting APIs for accelerated 2d canvas in WebKit2
Created attachment 175571 [details] Patch
Comment on attachment 175571 [details] Patch LGTM
Comment on attachment 175571 [details] Patch Clearing flags on attachment: 175571 Committed r135803: <http://trac.webkit.org/changeset/135803>
All reviewed patches have been landed. Closing bug.
Comment on attachment 175571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175571&action=review > Source/WebKit2/ChangeLog:8 > + Add setting APIs for accelerated 2d canvas in WebKit2. 2D! > Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:451 > +void WKPreferencesSetAccelerated2dCanvasEnabled(WKPreferencesRef preferencesRef, bool flag) Please no it is called 2D and not 2d! Please fix asap. Especially in public api
Comment on attachment 175571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175571&action=review >> Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:451 >> +void WKPreferencesSetAccelerated2dCanvasEnabled(WKPreferencesRef preferencesRef, bool flag) > > Please no it is called 2D and not 2d! Please fix asap. Especially in public api Other ports have used *2d* in WK1's APIs. So, I accepted this. However, I also think 2D is correct in WK2 C API level. Sorry.
Created attachment 176205 [details] patch_2D
Created attachment 176206 [details] patch_2D
Created attachment 176211 [details] patch_2D_rebase
Reopening to attach new patch.
Created attachment 176215 [details] Patch
*** Bug 103380 has been marked as a duplicate of this bug. ***
Comment on attachment 176215 [details] Patch Clearing flags on attachment: 176215 Committed r135843: <http://trac.webkit.org/changeset/135843>
(In reply to comment #3) > (From update of attachment 175571 [details]) > Clearing flags on attachment: 175571 > > Committed r135803: <http://trac.webkit.org/changeset/135803> Just out of curiosity, is there an implementation of this somewhere? (not only the preference flag, I mean...)
(In reply to comment #15) > (In reply to comment #3) > > (From update of attachment 175571 [details] [details]) > > Clearing flags on attachment: 175571 > > > > Committed r135803: <http://trac.webkit.org/changeset/135803> > > Just out of curiosity, is there an implementation of this somewhere? (not only the preference flag, I mean...) it will be uploaded within a few days..