Bug 102998 – [V8] Move AddMessageListener() from WorkerContextExecutionProxy::initializeIfNeeded() to WorkerContextExecutionProxy::initIsolate()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

This is an incremental step for moving initializeIfNeeded() to V8Initializer.h.

Given that AddMessageListener() needs to be called once per Isolate, we can move AddMessageListener() from initializeIfNeeded() to initIsolate().

[Kentaro Hara]

Created attachment 175558 [details]
Patch

[Kentaro Hara]

Comment on attachment 175558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175558&action=review

> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-135
> -    static bool isV8Initialized = false;
> -    if (!isV8Initialized)

Actually, isV8Initialized does nothing.

[WebKit Review Bot]

Comment on attachment 175558 [details]
Patch

Attachment 175558 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14966172

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

[Kentaro Hara]

(In reply to comment #3)
> New failing tests:
> platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

Looks like this failure is just a noise.

abarth: r?

[Adam Barth]

> Looks like this failure is just a noise.

Perhaps we should mark it as flaky.

[WebKit Review Bot]

Comment on attachment 175558 [details]
Patch

Clearing flags on attachment: 175558

Committed r135497: <http://trac.webkit.org/changeset/135497>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.