Bug 102997 - HTML integer parsing functions don't natively handle 8 bit strings
Summary: HTML integer parsing functions don't natively handle 8 bit strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 17:36 PST by Michael Saboff
Modified: 2012-11-22 01:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.34 KB, patch)
2012-11-21 17:49 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
Patch with needed WTF exports (6.22 KB, patch)
2012-11-21 17:55 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-11-21 17:36:50 PST 
The HTML integer parsing functions parseHTMLInteger() and parseHTMLNonNegativeInteger() both call characters() on the input string and process as a UChar*.  For 8 bit strings, the integer parsing can be done directly without upconverting to 16 bits.
Comment 1 Michael Saboff 2012-11-21 17:49:25 PST 
Created attachment 175556 [details]
Patch
Comment 2 Michael Saboff 2012-11-21 17:55:53 PST 
Created attachment 175557 [details]
Patch with needed WTF exports
Comment 3 WebKit Review Bot 2012-11-22 01:37:47 PST 
Comment on attachment 175557 [details]
Patch with needed WTF exports

Clearing flags on attachment: 175557

Committed r135495: <http://trac.webkit.org/changeset/135495>
Comment 4 WebKit Review Bot 2012-11-22 01:37:51 PST 
All reviewed patches have been landed.  Closing bug.