Bug 102995 - Remember the CachedResourceRequest for preloads
Summary: Remember the CachedResourceRequest for preloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks: 84883
  Show dependency tree / graph
 
Reported: 2012-11-21 17:22 PST by James Simonsen
Modified: 2012-11-30 11:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.32 KB, patch)
2012-11-21 17:24 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch (7.38 KB, patch)
2012-11-26 15:57 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Simonsen 2012-11-21 17:22:54 PST 
Remember the CachedResourceRequest for preloads
Comment 1 James Simonsen 2012-11-21 17:24:11 PST 
Created attachment 175554 [details]
Patch
Comment 2 Build Bot 2012-11-21 18:27:34 PST 
Comment on attachment 175554 [details]
Patch

Attachment 175554 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14963146

New failing tests:
fast/encoding/preload-encoding.html
Comment 3 WebKit Review Bot 2012-11-23 07:22:39 PST 
Comment on attachment 175554 [details]
Patch

Attachment 175554 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14959701

New failing tests:
fast/js/bom-in-file-retains-correct-offset.html
fast/regex/unicodeCaseInsensitive.html
fast/dom/attribute-legacy-colors.html
dom/html/level1/core/hc_attrgetvalue1.html
fast/encoding/preload-encoding.html
dom/html/level1/core/hc_textparseintolistofelements.html
editing/style/make-text-writing-direction-inline.html
Comment 4 James Simonsen 2012-11-26 15:57:48 PST 
Created attachment 176100 [details]
Patch
Comment 5 James Simonsen 2012-11-28 12:09:27 PST 
This is needed for Resource Timing. The initiator should be the same regardless of whether or not it's preloaded.
Comment 6 Marja Hölttä 2012-11-29 00:32:28 PST 
Ahh. This is also needed for our use cases. Thanks for fixing this!
Comment 7 Marja Hölttä 2012-11-29 00:34:00 PST 
... meaning that we probably also want to notify the embedder in requestPreload; that's not done yet.
Comment 8 WebKit Review Bot 2012-11-30 11:18:35 PST 
Comment on attachment 176100 [details]
Patch

Clearing flags on attachment: 176100

Committed r136255: <http://trac.webkit.org/changeset/136255>
Comment 9 WebKit Review Bot 2012-11-30 11:18:38 PST 
All reviewed patches have been landed.  Closing bug.