Bug 102993 - Remove hidden limiter div in the input slider shadow DOM
Summary: Remove hidden limiter div in the input slider shadow DOM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 102352
  Show dependency treegraph
 
Reported: 2012-11-21 16:53 PST by Tony Chang
Modified: 2012-11-27 13:40 PST (History)
14 users (show)

See Also:


Attachments
Patch (28.58 KB, patch)
2012-11-21 16:59 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (88.38 KB, patch)
2012-11-27 11:07 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (88.42 KB, patch)
2012-11-27 12:17 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-11-21 16:53:18 PST
Remove hidden limiter div in the input slider shadow DOM
Comment 1 Tony Chang 2012-11-21 16:59:54 PST
Created attachment 175548 [details]
Patch
Comment 2 Tony Chang 2012-11-21 17:01:17 PST
I still need to update TestExpecations for the other ports. I'll do that after Thanksgiving holiday.
Comment 3 Build Bot 2012-11-23 01:03:08 PST
Comment on attachment 175548 [details]
Patch

Attachment 175548 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14959601

New failing tests:
fast/forms/range/slider-thumb-stylability.html
media/video-playing-and-pause.html
fast/multicol/client-rects.html
fast/repaint/slider-thumb-drag-release.html
fast/repaint/slider-thumb-float.html
media/video-display-toggle.html
media/controls-styling-strict.html
media/audio-controls-rendering.html
fast/forms/input-appearance-height.html
media/video-controls-rendering.html
fast/dom/HTMLInputElement/input-slider-update.html
media/controls-without-preload.html
fast/forms/range/input-appearance-range.html
media/video-no-audio.html
fast/forms/range/slider-padding.html
fast/forms/box-shadow-override.html
media/controls-strict.html
fast/forms/range/range-thumb-height-percentage.html
media/controls-after-reload.html
fast/dom/HTMLInputElement/input-slider-update-styled.html
fast/forms/range/slider-thumb-shared-style.html
Comment 4 WebKit Review Bot 2012-11-23 18:48:38 PST
Comment on attachment 175548 [details]
Patch

Attachment 175548 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14961924

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
media/controls-styling.html
media/video-display-toggle.html
media/controls-styling-strict.html
media/audio-repaint.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
http/tests/media/video-buffered-range-contains-currentTime.html
media/video-controls-rendering.html
media/controls-without-preload.html
platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html
media/media-controls-clone.html
media/video-playing-and-pause.html
media/controls-after-reload.html
Comment 5 Tony Chang 2012-11-27 11:07:41 PST
Created attachment 176305 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-11-27 12:01:47 PST
Comment on attachment 176305 [details]
Patch for landing

Rejecting attachment 176305 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rce/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
52>At revision 167605.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 6 files

Full output: http://queues.webkit.org/results/15015186
Comment 7 Tony Chang 2012-11-27 12:17:33 PST
Created attachment 176321 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-11-27 13:09:31 PST
Comment on attachment 176321 [details]
Patch for landing

Rejecting attachment 176321 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
FLICT (content): Merge conflict in Source/WebKit/blackberry/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Unreviewed gardening. Add bug numbers to flaky tests.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/15013198
Comment 9 Tony Chang 2012-11-27 13:16:28 PST
Comment on attachment 176321 [details]
Patch for landing

Try again.
Comment 10 WebKit Review Bot 2012-11-27 13:40:04 PST
Comment on attachment 176321 [details]
Patch for landing

Clearing flags on attachment: 176321

Committed r135913: <http://trac.webkit.org/changeset/135913>
Comment 11 WebKit Review Bot 2012-11-27 13:40:10 PST
All reviewed patches have been landed.  Closing bug.