Bug 102988 - [EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1
Summary: [EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 16:18 PST by Ryuan Choi
Modified: 2012-11-21 22:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.07 KB, patch)
2012-11-21 16:20 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (1.12 KB, patch)
2012-11-21 16:22 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (1.13 KB, patch)
2012-11-21 19:17 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-11-21 16:18:13 PST
cmakeconfig.h already defines it when enabled.
Comment 1 Ryuan Choi 2012-11-21 16:20:12 PST
Created attachment 175544 [details]
Patch
Comment 2 Ryuan Choi 2012-11-21 16:22:55 PST
Created attachment 175545 [details]
Patch
Comment 3 Laszlo Gombos 2012-11-21 18:28:07 PST
Comment on attachment 175545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175545&action=review

> ChangeLog:8
> +        Removed -DENABLE_SPELLCHECK=1 because it is already defined by cmakeconfig.h

cmakeconfig.h seems to be generated. Did you mean OptionsEfl.cmake ?
Comment 4 Ryuan Choi 2012-11-21 19:17:45 PST
Created attachment 175568 [details]
Patch
Comment 5 Laszlo Gombos 2012-11-21 19:19:59 PST
Comment on attachment 175568 [details]
Patch

r=me.
Comment 6 Ryuan Choi 2012-11-21 22:19:31 PST
Committed r135477: <http://trac.webkit.org/changeset/135477>