RESOLVED FIXED 102986
REGRESSION(r135437): This patch causes crash to some layout tests (Requested by jianli on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=102986
Summary REGRESSION(r135437): This patch causes crash to some layout tests (Requested ...
WebKit Review Bot
Reported 2012-11-21 15:46:33 PST
http://trac.webkit.org/changeset/135437 broke the build: This patch causes crash to some layout tests (Requested by jianli on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r135437 (2.40 KB, patch)
2012-11-21 15:47 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-11-21 15:47:13 PST
Created attachment 175540 [details] ROLLOUT of r135437 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Jian Li
Comment 2 2012-11-21 15:48:22 PST
Here is the stack: /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/rendering/RenderObject.cpp(173) : static WebCore::RenderObject *WebCore::RenderObject::createObject(WebCore::Node *, WebCore::RenderStyle *) 1 0x102dbbc60 WebCore::RenderObject::createObject(WebCore::Node*, WebCore::RenderStyle*) 2 0x10221769e WebCore::HTMLElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*) 3 0x102b67b08 WebCore::NodeRenderingContext::createRendererIfNeeded() 4 0x102b4ef05 WebCore::Node::createRendererIfNeeded() 5 0x101fcc884 WebCore::Element::attach() Here're some bot output http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r135440%20(3070)/fast/css/xml-stylesheet-alternate-processing-stderr.txt http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/2052
WebKit Review Bot
Comment 3 2012-11-21 16:03:10 PST
Comment on attachment 175540 [details] ROLLOUT of r135437 Clearing flags on attachment: 175540 Committed r135447: <http://trac.webkit.org/changeset/135447>
WebKit Review Bot
Comment 4 2012-11-21 16:03:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.