Bug 102984 - IndexedDB: Simplify transaction timers and event tracking
Summary: IndexedDB: Simplify transaction timers and event tracking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 15:18 PST by Joshua Bell
Modified: 2012-11-30 14:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.39 KB, patch)
2012-11-21 15:28 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (20.08 KB, patch)
2012-11-21 16:00 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (20.68 KB, patch)
2012-11-27 10:42 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch for landing (20.79 KB, patch)
2012-11-27 14:47 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-11-21 15:18:33 PST 
IndexedDB: Simplify transaction timers and event tracking
Comment 1 Joshua Bell 2012-11-21 15:28:38 PST 
Created attachment 175536 [details]
Patch
Comment 2 Joshua Bell 2012-11-21 15:30:11 PST 
NOTE: http://crrev.com/11280128 needs to land first.

(There some Chromium public WebKit API cleanup that can be done after this lands, as well as some cleanup inside Chromium itself.)
Comment 3 Joshua Bell 2012-11-21 15:30:54 PST 
dgrogan@, alecflett@ - please take a look once Tryptophan levels have diminished to a reasonable level?
Comment 4 Joshua Bell 2012-11-21 16:00:40 PST 
Created attachment 175541 [details]
Patch
Comment 5 Joshua Bell 2012-11-21 16:01:33 PST 
Updated patch - removed the Chromium public WebKit API impls. Just leaves an ASSERT_NOT_REACHED() impl in WebIDBTransaction.h
Comment 6 Joshua Bell 2012-11-27 09:41:51 PST 
Now that turkey day has passed - alecflett@, dgrogan@ - please take a look?
Comment 7 Alec Flett 2012-11-27 10:33:19 PST 
Comment on attachment 175541 [details]
Patch

Other than a comment request, this looks great. LGTM

View in context: https://bugs.webkit.org/attachment.cgi?id=175541&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:504
>      if (m_transaction) {

Now I'm wondering when we do and don't have an m_transaction - do you know? If so, add a comment..
Comment 8 Joshua Bell 2012-11-27 10:36:34 PST 
(In reply to comment #7)
> (From update of attachment 175541 [details])
> Other than a comment request, this looks great. LGTM
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=175541&action=review
> 
> > Source/WebCore/Modules/indexeddb/IDBRequest.cpp:504
> >      if (m_transaction) {
> 
> Now I'm wondering when we do and don't have an m_transaction - do you know? If so, add a comment..

The IDBFactory methods (open/deleteDatabase/getDatabaseNames) are the only cases.

I'll add a comment.
Comment 9 Joshua Bell 2012-11-27 10:42:04 PST 
Created attachment 176298 [details]
Patch
Comment 10 Joshua Bell 2012-11-27 10:44:55 PST 
tony@ - r?
Comment 11 Joshua Bell 2012-11-27 14:47:54 PST 
Created attachment 176343 [details]
Patch for landing
Comment 12 WebKit Review Bot 2012-11-27 15:09:06 PST 
Comment on attachment 176343 [details]
Patch for landing

Clearing flags on attachment: 176343

Committed r135927: <http://trac.webkit.org/changeset/135927>
Comment 13 WebKit Review Bot 2012-11-27 15:09:10 PST 
All reviewed patches have been landed.  Closing bug.