Bug 102980 - [BlackBerry] Drop Synchronous Mouse Events
Summary: [BlackBerry] Drop Synchronous Mouse Events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 14:37 PST by gmak
Modified: 2012-11-23 08:12 PST (History)
4 users (show)

See Also:


Attachments
Patch - Cleanup and send click (25.04 KB, patch)
2012-11-21 15:15 PST, gmak
no flags Details | Formatted Diff | Diff
Patch - handle fullscreen plugins (7.89 KB, patch)
2012-11-21 15:16 PST, gmak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gmak 2012-11-21 14:37:01 PST
Send only clicks.
Comment 1 gmak 2012-11-21 15:15:39 PST
Created attachment 175534 [details]
Patch - Cleanup and send click
Comment 2 gmak 2012-11-21 15:16:19 PST
Created attachment 175535 [details]
Patch - handle fullscreen plugins
Comment 3 Rob Buis 2012-11-21 15:19:04 PST
Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

LGTM.
Comment 4 Rob Buis 2012-11-21 15:22:10 PST
Comment on attachment 175534 [details]
Patch - Cleanup and send click

View in context: https://bugs.webkit.org/attachment.cgi?id=175534&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:4022
> +        d->m_touchEventHandler->doFatFingers(tEvent.m_points[0]);

Not fond of doFatFingers name.
Comment 5 WebKit Review Bot 2012-11-21 15:43:12 PST
Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Rejecting attachment 175535 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
p
Hunk #1 FAILED at 4045.
Hunk #2 succeeded at 4131 (offset 5 lines).
Hunk #3 succeeded at 4192 (offset 5 lines).
Hunk #4 succeeded at 4202 (offset 5 lines).
1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14962151
Comment 6 WebKit Review Bot 2012-11-21 16:00:48 PST
Comment on attachment 175534 [details]
Patch - Cleanup and send click

Clearing flags on attachment: 175534

Committed r135446: <http://trac.webkit.org/changeset/135446>
Comment 7 WebKit Review Bot 2012-11-21 17:52:36 PST
Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Rejecting attachment 175535 [details] from commit-queue.

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
Full output: http://queues.webkit.org/results/14937178
Comment 8 WebKit Review Bot 2012-11-23 08:12:22 PST
Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Clearing flags on attachment: 175535

Committed r135613: <http://trac.webkit.org/changeset/135613>
Comment 9 WebKit Review Bot 2012-11-23 08:12:25 PST
All reviewed patches have been landed.  Closing bug.