Bug 102980 – [BlackBerry] Drop Synchronous Mouse Events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

Send only clicks.

Created attachment 175534 [details]
Patch - Cleanup and send click

Created attachment 175535 [details]
Patch - handle fullscreen plugins

[Rob Buis]

Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

LGTM.

[Rob Buis]

Comment on attachment 175534 [details]
Patch - Cleanup and send click

View in context: https://bugs.webkit.org/attachment.cgi?id=175534&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:4022
> +        d->m_touchEventHandler->doFatFingers(tEvent.m_points[0]);

Not fond of doFatFingers name.

[WebKit Review Bot]

Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Rejecting attachment 175535 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
p
Hunk #1 FAILED at 4045.
Hunk #2 succeeded at 4131 (offset 5 lines).
Hunk #3 succeeded at 4192 (offset 5 lines).
Hunk #4 succeeded at 4202 (offset 5 lines).
1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14962151

[WebKit Review Bot]

Comment on attachment 175534 [details]
Patch - Cleanup and send click

Clearing flags on attachment: 175534

Committed r135446: <http://trac.webkit.org/changeset/135446>

[WebKit Review Bot]

Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Rejecting attachment 175535 [details] from commit-queue.

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
Full output: http://queues.webkit.org/results/14937178

[WebKit Review Bot]

Comment on attachment 175535 [details]
Patch - handle fullscreen plugins

Clearing flags on attachment: 175535

Committed r135613: <http://trac.webkit.org/changeset/135613>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.