RESOLVED FIXED 102974
Remove unnecessary ternaries in createRendererIfNeeded 
https://bugs.webkit.org/show_bug.cgi?id=102974
Summary Remove unnecessary ternaries in createRendererIfNeeded
Elliott Sprehn
Reported 2012-11-21 13:13:21 PST
Remove unnecessary ternaries in createRendererIfNeeded
Attachments
Patch (1.94 KB, patch)
2012-11-21 13:15 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.17 KB, patch)
2012-11-21 13:55 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-11-21 13:15:50 PST
Created attachment 175506 [details] Patch
Ojan Vafai
Comment 2 2012-11-21 13:25:13 PST
Comment on attachment 175506 [details] Patch Is it possible for m_parentFlowRenderer to be set and m_node->renderer() to be non-null? If so, then this code isn't actually equivalent. That said, maybe you can change parentRenderer/etc. to check m_parentFlowRenderer first?
Elliott Sprehn
Comment 3 2012-11-21 13:28:18 PST
(In reply to comment #2) > (From update of attachment 175506 [details]) > Is it possible for m_parentFlowRenderer to be set and m_node->renderer() to be non-null? If so, then this code isn't actually equivalent. > > That said, maybe you can change parentRenderer/etc. to check m_parentFlowRenderer first? No, because we assert at the top of this method: ASSERT(!m_node->renderer()); Calling createRendererIfNeeded() if you already have a renderer is a bug.
Ojan Vafai
Comment 4 2012-11-21 13:43:50 PST
Comment on attachment 175506 [details] Patch Might be worth mentioning the asserts in the changelog.
Elliott Sprehn
Comment 5 2012-11-21 13:55:47 PST
Created attachment 175515 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-11-21 14:22:22 PST
Comment on attachment 175515 [details] Patch for landing Clearing flags on attachment: 175515 Committed r135432: <http://trac.webkit.org/changeset/135432>
WebKit Review Bot
Comment 7 2012-11-21 14:22:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.