RESOLVED FIXED 102955
Web Inspector: Allow sorting in NMI snapshot grid view 
https://bugs.webkit.org/show_bug.cgi?id=102955
Summary Web Inspector: Allow sorting in NMI snapshot grid view
Alexei Filippov
Reported 2012-11-21 09:47:23 PST
EOM
Attachments
Patch (6.66 KB, patch)
2012-11-21 09:50 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (7.68 KB, patch)
2012-11-28 12:09 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-11-21 09:50:19 PST
Created attachment 175468 [details] Patch
Yury Semikhatsky
Comment 2 2012-11-26 01:42:28 PST
Comment on attachment 175468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175468&action=review > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:66 > + this._totalNode = totalNode; You will need to rebase. > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:73 > + this._storedState = {}; _storedState -> _expandedNodes ? also you can pass the map as a parameter to _storeState/_restoreState > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:134 > + get data() Please use function instead of getter. > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:141 > + if (!this.expanded) return; style nit: return on the next line > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:149 > + if (!this.dataGrid._storedState[this.uid]) return; style nit: return on the next line > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:158 > + get uid() We recently decided to prefer function to getters/setters. Please use uid: function() here.
Alexei Filippov
Comment 3 2012-11-28 12:02:45 PST
Comment on attachment 175468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175468&action=review >> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:66 >> + this._totalNode = totalNode; > > You will need to rebase. ok >> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:73 >> + this._storedState = {}; > > _storedState -> _expandedNodes ? also you can pass the map as a parameter to _storeState/_restoreState ok >> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:134 >> + get data() > > Please use function instead of getter. ok >> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:141 >> + if (!this.expanded) return; > > style nit: return on the next line ok >> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:158 >> + get uid() > > We recently decided to prefer function to getters/setters. Please use uid: function() here. ok
Alexei Filippov
Comment 4 2012-11-28 12:09:07 PST
Created attachment 176539 [details] Patch
WebKit Review Bot
Comment 5 2012-11-29 14:17:15 PST
Comment on attachment 176539 [details] Patch Clearing flags on attachment: 176539 Committed r136163: <http://trac.webkit.org/changeset/136163>
WebKit Review Bot
Comment 6 2012-11-29 14:17:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.