Bug 102953 - [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
Summary: [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 98347
  Show dependency tree / graph
 
Reported: 2012-11-21 09:33 PST by Zan Dobersek
Modified: 2012-12-10 03:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2012-11-21 09:35 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (3.18 KB, patch)
2012-12-10 02:45 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-11-21 09:33:59 PST 
[GTK][WTR] Implement AccessibilityUIElement::titleUIElement
Comment 1 Zan Dobersek 2012-11-21 09:35:45 PST 
Created attachment 175465 [details]
Patch
Comment 2 Martin Robinson 2012-11-21 13:30:24 PST 
Hrm. Doesn't this change test results?
Comment 3 Zan Dobersek 2012-11-21 13:46:49 PST 
(In reply to comment #2)
> Hrm. Doesn't this change test results?

No, it brings the WTR in line with DRT so wk1 baselines can be used without the tests failing in WTR. The affected tests are currently failing on WK2 builder, with the patch they pass.
Comment 4 Martin Robinson 2012-11-21 14:57:38 PST 
Comment on attachment 175465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274
> +        g_object_unref(set);

Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation)
Comment 5 Zan Dobersek 2012-11-22 01:09:40 PST 
Comment on attachment 175465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274
>> +        g_object_unref(set);
> 
> Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation)

Yeah, that looks wrong. The statement should probably be moved outside the loop. Mario or Joanie should have a look.
Comment 6 Zan Dobersek 2012-12-10 02:45:06 PST 
Created attachment 178497 [details]
Patch
Comment 7 Zan Dobersek 2012-12-10 03:31:33 PST 
Comment on attachment 178497 [details]
Patch

Clearing flags on attachment: 178497

Committed r137130: <http://trac.webkit.org/changeset/137130>
Comment 8 Zan Dobersek 2012-12-10 03:31:41 PST 
All reviewed patches have been landed.  Closing bug.