Bug 102953 – [GTK][WTR] Implement AccessibilityUIElement::titleUIElement

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[GTK][WTR] Implement AccessibilityUIElement::titleUIElement

[Zan Dobersek]

Created attachment 175465 [details]
Patch

[Martin Robinson]

Hrm. Doesn't this change test results?

[Zan Dobersek]

(In reply to comment #2)
> Hrm. Doesn't this change test results?

No, it brings the WTR in line with DRT so wk1 baselines can be used without the tests failing in WTR. The affected tests are currently failing on WK2 builder, with the patch they pass.

[Martin Robinson]

Comment on attachment 175465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274
> +        g_object_unref(set);

Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation)

[Zan Dobersek]

Comment on attachment 175465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274
>> +        g_object_unref(set);
> 
> Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation)

Yeah, that looks wrong. The statement should probably be moved outside the loop. Mario or Joanie should have a look.

[Zan Dobersek]

Created attachment 178497 [details]
Patch

[Zan Dobersek]

Comment on attachment 178497 [details]
Patch

Clearing flags on attachment: 178497

Committed r137130: <http://trac.webkit.org/changeset/137130>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.