Bug 102952 - [chromium] Make use_default_render_theme compile the right set of files
Summary: [chromium] Make use_default_render_theme compile the right set of files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 09:29 PST by Scott Violet
Modified: 2012-11-26 07:02 PST (History)
7 users (show)

See Also:


Attachments
Patch (8.12 KB, patch)
2012-11-21 14:15 PST, Scott Violet
no flags Details | Formatted Diff | Diff
Patch (8.10 KB, patch)
2012-11-21 14:54 PST, Scott Violet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2012-11-21 09:29:23 PST
Additionally need to copy public/linux/WebRenderTheme to public/default.
Comment 1 Scott Violet 2012-11-21 14:15:37 PST
Created attachment 175522 [details]
Patch
Comment 2 Scott Violet 2012-11-21 14:17:15 PST
WebKit DEPS was rolled, so this compiles for me outside of chrome.
Comment 3 WebKit Review Bot 2012-11-21 14:18:18 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Tony Chang 2012-11-21 14:28:39 PST
Comment on attachment 175522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175522&action=review

LGTM

> Source/WebKit/chromium/WebKit.gyp:853
> +                }],
> +                ['use_default_render_theme==0', {

Nit: I would make this an else clause (delete from ] to the second ' inclusive).
Comment 5 Scott Violet 2012-11-21 14:54:00 PST
Created attachment 175528 [details]
Patch
Comment 6 Scott Violet 2012-11-21 14:54:48 PST
Newest patch converts to else syntax as outlined in comment 4.
Comment 7 Kent Tamura 2012-11-21 19:31:44 PST
Comment on attachment 175528 [details]
Patch

ok
Comment 8 WebKit Review Bot 2012-11-26 07:02:11 PST
Comment on attachment 175528 [details]
Patch

Clearing flags on attachment: 175528

Committed r135718: <http://trac.webkit.org/changeset/135718>
Comment 9 WebKit Review Bot 2012-11-26 07:02:15 PST
All reviewed patches have been landed.  Closing bug.