WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102952
[chromium] Make use_default_render_theme compile the right set of files
https://bugs.webkit.org/show_bug.cgi?id=102952
Summary
[chromium] Make use_default_render_theme compile the right set of files
Scott Violet
Reported
2012-11-21 09:29:23 PST
Additionally need to copy public/linux/WebRenderTheme to public/default.
Attachments
Patch
(8.12 KB, patch)
2012-11-21 14:15 PST
,
Scott Violet
no flags
Details
Formatted Diff
Diff
Patch
(8.10 KB, patch)
2012-11-21 14:54 PST
,
Scott Violet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Scott Violet
Comment 1
2012-11-21 14:15:37 PST
Created
attachment 175522
[details]
Patch
Scott Violet
Comment 2
2012-11-21 14:17:15 PST
WebKit DEPS was rolled, so this compiles for me outside of chrome.
WebKit Review Bot
Comment 3
2012-11-21 14:18:18 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
Tony Chang
Comment 4
2012-11-21 14:28:39 PST
Comment on
attachment 175522
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=175522&action=review
LGTM
> Source/WebKit/chromium/WebKit.gyp:853 > + }], > + ['use_default_render_theme==0', {
Nit: I would make this an else clause (delete from ] to the second ' inclusive).
Scott Violet
Comment 5
2012-11-21 14:54:00 PST
Created
attachment 175528
[details]
Patch
Scott Violet
Comment 6
2012-11-21 14:54:48 PST
Newest patch converts to else syntax as outlined in
comment 4
.
Kent Tamura
Comment 7
2012-11-21 19:31:44 PST
Comment on
attachment 175528
[details]
Patch ok
WebKit Review Bot
Comment 8
2012-11-26 07:02:11 PST
Comment on
attachment 175528
[details]
Patch Clearing flags on attachment: 175528 Committed
r135718
: <
http://trac.webkit.org/changeset/135718
>
WebKit Review Bot
Comment 9
2012-11-26 07:02:15 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug