Bug 102941 - IDBRequestTest needs a v8 context
Summary: IDBRequestTest needs a v8 context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 102959
Blocks: 101573
  Show dependency tree / graph
 
Reported: 2012-11-21 07:29 PST by Dan Carney
Modified: 2012-11-22 05:17 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2012-11-21 07:30 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2012-11-21 07:55 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Patch (4.41 KB, patch)
2012-11-22 00:35 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2012-11-21 07:29:24 PST 
IDBRequestTest needs a v8 context
Comment 1 Dan Carney 2012-11-21 07:30:21 PST 
Created attachment 175441 [details]
Patch
Comment 2 jochen 2012-11-21 07:37:04 PST 
Comment on attachment 175441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175441&action=review

> Source/WebKit/chromium/tests/IDBRequestTest.cpp:68
> +    v8::Handle<v8::Context> context()

can you call this v8Context() so it doesn't collide with the variables named "context" in the test?
Comment 3 Dan Carney 2012-11-21 07:55:00 PST 
Created attachment 175447 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-21 09:17:49 PST 
Comment on attachment 175447 [details]
Patch

Clearing flags on attachment: 175447

Committed r135409: <http://trac.webkit.org/changeset/135409>
Comment 5 WebKit Review Bot 2012-11-21 09:17:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-11-21 10:13:59 PST 
Re-opened since this is blocked by bug 102959
Comment 7 Dan Carney 2012-11-22 00:35:34 PST 
Created attachment 175608 [details]
Patch
Comment 8 Dan Carney 2012-11-22 01:21:04 PST 
Comment on attachment 175608 [details]
Patch

now with mac support
Comment 9 WebKit Review Bot 2012-11-22 05:17:29 PST 
Comment on attachment 175608 [details]
Patch

Clearing flags on attachment: 175608

Committed r135506: <http://trac.webkit.org/changeset/135506>
Comment 10 WebKit Review Bot 2012-11-22 05:17:32 PST 
All reviewed patches have been landed.  Closing bug.