RESOLVED FIXED 102917
[V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() 
https://bugs.webkit.org/show_bug.cgi?id=102917
Summary [V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
Kentaro Hara
Reported 2012-11-21 03:06:07 PST
Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
Attachments
Patch (39.68 KB, patch)
2012-11-21 03:13 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-21 03:13:02 PST
Created attachment 175400 [details] Patch
Adam Barth
Comment 2 2012-11-21 03:19:53 PST
Comment on attachment 175400 [details] Patch Can we also rename V8Parameter to something sensible?
Kentaro Hara
Comment 3 2012-11-21 03:21:22 PST
(In reply to comment #2) > (From update of attachment 175400 [details]) > Can we also rename V8Parameter to something sensible? Yes, do you have any suggestion? StringOrAtomicString? WebCoreString?
Adam Barth
Comment 4 2012-11-21 03:21:57 PST
V8StringConverter ?
Kentaro Hara
Comment 5 2012-11-21 03:22:33 PST
(In reply to comment #4) > V8StringConverter ? Sounds good.
Adam Barth
Comment 6 2012-11-21 03:24:43 PST
Perhaps V8StringResource since that's the header it is in?
Kentaro Hara
Comment 7 2012-11-21 03:33:15 PST
(In reply to comment #6) > Perhaps V8StringResource since that's the header it is in? Sounds better:)
WebKit Review Bot
Comment 8 2012-11-21 03:43:54 PST
Comment on attachment 175400 [details] Patch Clearing flags on attachment: 175400 Committed r135378: <http://trac.webkit.org/changeset/135378>
WebKit Review Bot
Comment 9 2012-11-21 03:43:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.