Bug 102917 - [V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
Summary: [V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 03:06 PST by Kentaro Hara
Modified: 2012-11-21 03:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (39.68 KB, patch)
2012-11-21 03:13 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-21 03:06:07 PST 
Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
Comment 1 Kentaro Hara 2012-11-21 03:13:02 PST 
Created attachment 175400 [details]
Patch
Comment 2 Adam Barth 2012-11-21 03:19:53 PST 
Comment on attachment 175400 [details]
Patch

Can we also rename V8Parameter to something sensible?
Comment 3 Kentaro Hara 2012-11-21 03:21:22 PST 
(In reply to comment #2)
> (From update of attachment 175400 [details])
> Can we also rename V8Parameter to something sensible?

Yes, do you have any suggestion? StringOrAtomicString? WebCoreString?
Comment 4 Adam Barth 2012-11-21 03:21:57 PST 
V8StringConverter ?
Comment 5 Kentaro Hara 2012-11-21 03:22:33 PST 
(In reply to comment #4)
> V8StringConverter ?

Sounds good.
Comment 6 Adam Barth 2012-11-21 03:24:43 PST 
Perhaps V8StringResource since that's the header it is in?
Comment 7 Kentaro Hara 2012-11-21 03:33:15 PST 
(In reply to comment #6)
> Perhaps V8StringResource since that's the header it is in?

Sounds better:)
Comment 8 WebKit Review Bot 2012-11-21 03:43:54 PST 
Comment on attachment 175400 [details]
Patch

Clearing flags on attachment: 175400

Committed r135378: <http://trac.webkit.org/changeset/135378>
Comment 9 WebKit Review Bot 2012-11-21 03:43:57 PST 
All reviewed patches have been landed.  Closing bug.