Bug 102915 - WebMediaStreamComponent: Add missing assignment and copy operators
Summary: WebMediaStreamComponent: Add missing assignment and copy operators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Harald Alvestrand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 03:00 PST by Harald Alvestrand
Modified: 2012-11-21 03:49 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.76 KB, patch)
2012-11-21 03:15 PST, Harald Alvestrand 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2012-11-21 03:23 PST, Harald Alvestrand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Alvestrand 2012-11-21 03:00:51 PST 
This class should be copyable like the others of its class family.
Comment 1 Harald Alvestrand 2012-11-21 03:15:42 PST 
Created attachment 175401 [details]
Patch
Comment 2 Adam Barth 2012-11-21 03:20:34 PST 
Comment on attachment 175401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175401&action=review

> Source/WebCore/platform/chromium/support/WebMediaStreamComponent.cpp:89
> +

You've got an extra line here.
Comment 3 Harald Alvestrand 2012-11-21 03:22:52 PST 
Comment on attachment 175401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175401&action=review

>> Source/WebCore/platform/chromium/support/WebMediaStreamComponent.cpp:89
>> +
> 
> You've got an extra line here.

Fixed.
Comment 4 Harald Alvestrand 2012-11-21 03:23:57 PST 
Created attachment 175403 [details]
Patch
Comment 5 Adam Barth 2012-11-21 03:25:36 PST 
Comment on attachment 175403 [details]
Patch

Thanks.
Comment 6 WebKit Review Bot 2012-11-21 03:28:24 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 7 WebKit Review Bot 2012-11-21 03:49:10 PST 
Comment on attachment 175403 [details]
Patch

Clearing flags on attachment: 175403

Committed r135379: <http://trac.webkit.org/changeset/135379>
Comment 8 WebKit Review Bot 2012-11-21 03:49:15 PST 
All reviewed patches have been landed.  Closing bug.