Bug 102912 - [Shadow DOM] Implement Element::shadowRoot with prefix
Summary: [Shadow DOM] Implement Element::shadowRoot with prefix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords: WebExposed
Depends on:
Blocks: 63606
  Show dependency treegraph
 
Reported: 2012-11-21 02:49 PST by Hajime Morrita
Modified: 2012-12-06 23:29 PST (History)
16 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2012-12-05 22:20 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2012-12-06 18:41 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (25.08 KB, patch)
2012-12-06 20:58 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Hajime Morrita 2012-12-05 22:20:13 PST
Created attachment 177937 [details]
Patch
Comment 2 Build Bot 2012-12-06 02:42:34 PST
Comment on attachment 177937 [details]
Patch

Attachment 177937 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15152784

New failing tests:
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLInputElement/input-slider-update.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/console-resource-errors.html
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/file/file-style-inheritance.html
http/tests/cookies/single-quoted-value.html
fast/forms/range/input-appearance-range.html
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/css/input-search-padding.html
fast/forms/control-restrict-line-height.html
fast/forms/file/input-file-re-render.html
fast/forms/file/file-input-disabled.html
fast/forms/range/range-drag.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/forms/file/file-input-direction.html
accessibility/media-element.html
fast/block/block-remove-child-delete-line-box-crash.html
fast/forms/range/range-drag-when-toggled-disabled.html
fast/forms/number/number-size.html
fast/dom/HTMLProgressElement/indeterminate-progress-001.html
fast/dom/HTMLInputElement/input-slider-update-styled.html
fast/forms/number/number-appearance-spinbutton-layer.html
fast/forms/number/number-large-padding.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/forms/box-shadow-override.html
Comment 3 Dominic Cooney 2012-12-06 02:44:43 PST
Comment on attachment 177937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177937&action=review

> Source/WebCore/dom/Element.cpp:1383
> +    if (shadowRoot->type() != ShadowRoot::AuthorShadowRoot)

Is it worth writing a method with a name that reflects the intent? This condition is shared with olderShadowRoot.
Comment 4 Hajime Morrita 2012-12-06 17:42:44 PST
(In reply to comment #3)
> 
> > Source/WebCore/dom/Element.cpp:1383
> > +    if (shadowRoot->type() != ShadowRoot::AuthorShadowRoot)
> 
> Is it worth writing a method with a name that reflects the intent? This condition is shared with olderShadowRoot.
Right. isAccessible() ?
Comment 5 Hajime Morrita 2012-12-06 18:41:03 PST
Created attachment 178131 [details]
Patch
Comment 6 Dimitri Glazkov (Google) 2012-12-06 20:04:27 PST
Wrong patch? :)
Comment 7 Hajime Morrita 2012-12-06 20:23:04 PST
Comment on attachment 178131 [details]
Patch

;-(
Comment 8 Hajime Morrita 2012-12-06 20:58:33 PST
Created attachment 178151 [details]
Patch
Comment 9 Hajime Morrita 2012-12-06 20:59:28 PST
Fixed broken tests. The patch becomes bigger but most of the diff  is about a renaming.
Comment 10 Dimitri Glazkov (Google) 2012-12-06 21:06:40 PST
Comment on attachment 178151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178151&action=review

> Source/WebCore/dom/Node.cpp:1381
>      while (root) {

Whoa -- why is this not a treeScope lookup?
Comment 11 Hajime Morrita 2012-12-06 22:43:46 PST
Comment on attachment 178151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178151&action=review

>> Source/WebCore/dom/Node.cpp:1381
>>      while (root) {
> 
> Whoa -- why is this not a treeScope lookup?

Dunno but good catch. IIRC this is a result of a series of refactoring. Filed Bug 104342 for using treeScope().
Comment 12 WebKit Review Bot 2012-12-06 23:21:15 PST
Comment on attachment 178151 [details]
Patch

Clearing flags on attachment: 178151

Committed r136924: <http://trac.webkit.org/changeset/136924>
Comment 13 WebKit Review Bot 2012-12-06 23:21:19 PST
All reviewed patches have been landed.  Closing bug.