Bug 102912 – [Shadow DOM] Implement Element::shadowRoot with prefix

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#extensions-to-element

[Hajime Morrita]

Created attachment 177937 [details]
Patch

[Build Bot]

Comment on attachment 177937 [details]
Patch

Attachment 177937 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15152784

New failing tests:
fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-writing-mode.html
fast/dom/HTMLInputElement/input-slider-update.html
fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
http/tests/inspector/console-resource-errors.html
fast/forms/number/number-appearance-rtl.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/file/file-style-inheritance.html
http/tests/cookies/single-quoted-value.html
fast/forms/range/input-appearance-range.html
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/css/input-search-padding.html
fast/forms/control-restrict-line-height.html
fast/forms/file/input-file-re-render.html
fast/forms/file/file-input-disabled.html
fast/forms/range/range-drag.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/forms/file/file-input-direction.html
accessibility/media-element.html
fast/block/block-remove-child-delete-line-box-crash.html
fast/forms/range/range-drag-when-toggled-disabled.html
fast/forms/number/number-size.html
fast/dom/HTMLProgressElement/indeterminate-progress-001.html
fast/dom/HTMLInputElement/input-slider-update-styled.html
fast/forms/number/number-appearance-spinbutton-layer.html
fast/forms/number/number-large-padding.html
fast/dom/HTMLMeterElement/meter-styles.html
fast/forms/box-shadow-override.html

[Dominic Cooney]

Comment on attachment 177937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177937&action=review

> Source/WebCore/dom/Element.cpp:1383
> +    if (shadowRoot->type() != ShadowRoot::AuthorShadowRoot)

Is it worth writing a method with a name that reflects the intent? This condition is shared with olderShadowRoot.

[Hajime Morrita]

(In reply to comment #3)
> 
> > Source/WebCore/dom/Element.cpp:1383
> > +    if (shadowRoot->type() != ShadowRoot::AuthorShadowRoot)
> 
> Is it worth writing a method with a name that reflects the intent? This condition is shared with olderShadowRoot.
Right. isAccessible() ?

[Hajime Morrita]

Created attachment 178131 [details]
Patch

[Dimitri Glazkov (Google)]

Wrong patch? :)

[Hajime Morrita]

Comment on attachment 178131 [details]
Patch

;-(

[Hajime Morrita]

Created attachment 178151 [details]
Patch

[Hajime Morrita]

Fixed broken tests. The patch becomes bigger but most of the diff  is about a renaming.

[Dimitri Glazkov (Google)]

Comment on attachment 178151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178151&action=review

> Source/WebCore/dom/Node.cpp:1381
>      while (root) {

Whoa -- why is this not a treeScope lookup?

[Hajime Morrita]

Comment on attachment 178151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178151&action=review

>> Source/WebCore/dom/Node.cpp:1381
>>      while (root) {
> 
> Whoa -- why is this not a treeScope lookup?

Dunno but good catch. IIRC this is a result of a series of refactoring. Filed Bug 104342 for using treeScope().

[WebKit Review Bot]

Comment on attachment 178151 [details]
Patch

Clearing flags on attachment: 178151

Committed r136924: <http://trac.webkit.org/changeset/136924>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.