Bug 102909 - Position in QWebHitTestResult does not match documentation
Summary: Position in QWebHitTestResult does not match documentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on: 98139
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-21 02:29 PST by Allan Sandfeld Jensen
Modified: 2012-11-21 16:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2012-11-21 02:50 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2012-11-21 09:08 PST, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-21 02:29:26 PST 
The position in QWebHitTestResult is documented as 'the position where the hit-test occured', but the point from HitTestResult that we use to initialize this value with is the point in inner most hit frame, and not the original hit-test point.
Comment 1 Allan Sandfeld Jensen 2012-11-21 02:50:03 PST 
Created attachment 175396 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-11-21 08:35:07 PST 
Comment on attachment 175396 [details]
Patch

How does this work, if I do a QWebFrame::hitTestContent on a sub-frame, what position will QWebHitTestResult::pos return me?
Comment 3 Allan Sandfeld Jensen 2012-11-21 08:45:14 PST 
(In reply to comment #2)
> (From update of attachment 175396 [details])
> How does this work, if I do a QWebFrame::hitTestContent on a sub-frame, what position will QWebHitTestResult::pos return me?

Hit-testing a sub-frame will automatically be escalated to hit test in the main-frame. So essentially you can't.
Comment 4 Allan Sandfeld Jensen 2012-11-21 09:08:08 PST 
Created attachment 175456 [details]
Patch

Do not change behaviour, change documentation
Comment 5 WebKit Review Bot 2012-11-21 16:03:53 PST 
Comment on attachment 175456 [details]
Patch

Clearing flags on attachment: 175456

Committed r135449: <http://trac.webkit.org/changeset/135449>
Comment 6 WebKit Review Bot 2012-11-21 16:03:57 PST 
All reviewed patches have been landed.  Closing bug.