Bug 102906 - Web Inspector: Ctrl+A closes breakpoint condition editor
Summary: Web Inspector: Ctrl+A closes breakpoint condition editor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 01:58 PST by Andrey Lushnikov
Modified: 2012-11-21 09:35 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.60 KB, patch)
2012-11-21 02:14 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2012-11-21 02:43 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2012-11-21 08:39 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2012-11-21 01:58:03 PST 
Steps to reproduce:
1. Open dev-tools
2. Go to Sources
3. Open any js file
4. right click on a line-number -> add conditional breakpoint
5. Click Ctrl+A

What happens:
Conditional breakpoint editing window gets hidden; source code gets selected

What should happen: 
Text inside conditional breakpoint editor should get selected
Comment 1 Andrey Lushnikov 2012-11-21 02:14:46 PST 
Created attachment 175384 [details]
Patch
Comment 2 Andrey Lushnikov 2012-11-21 02:43:37 PST 
Created attachment 175390 [details]
Patch
Comment 3 Andrey Adaikin 2012-11-21 04:16:53 PST 
Comment on attachment 175390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:421
> +        if (WebInspector.currentFocusElement().nodeName === "INPUT")

call WebInspector.isBeingEdited(e.target) maybe?
Comment 4 Pavel Feldman 2012-11-21 04:28:14 PST 
Comment on attachment 175390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review

>> Source/WebCore/inspector/front-end/DefaultTextEditor.js:421
>> +        if (WebInspector.currentFocusElement().nodeName === "INPUT")
> 
> call WebInspector.isBeingEdited(e.target) maybe?

You can edit text in non-INPUT fields as well. Imagine if we switch conditional breakpoints to the text area... You should check that e.target has no ancestors with className "webkit-line-decorations" instead.
Comment 5 Andrey Lushnikov 2012-11-21 08:39:56 PST 
Created attachment 175454 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-21 09:35:02 PST 
Comment on attachment 175454 [details]
Patch

Clearing flags on attachment: 175454

Committed r135412: <http://trac.webkit.org/changeset/135412>
Comment 7 WebKit Review Bot 2012-11-21 09:35:06 PST 
All reviewed patches have been landed.  Closing bug.