RESOLVED FIXED 102906
Web Inspector: Ctrl+A closes breakpoint condition editor 
https://bugs.webkit.org/show_bug.cgi?id=102906
Summary Web Inspector: Ctrl+A closes breakpoint condition editor
Andrey Lushnikov
Reported 2012-11-21 01:58:03 PST
Steps to reproduce: 1. Open dev-tools 2. Go to Sources 3. Open any js file 4. right click on a line-number -> add conditional breakpoint 5. Click Ctrl+A What happens: Conditional breakpoint editing window gets hidden; source code gets selected What should happen: Text inside conditional breakpoint editor should get selected
Attachments
Patch (3.60 KB, patch)
2012-11-21 02:14 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.64 KB, patch)
2012-11-21 02:43 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2012-11-21 08:39 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2012-11-21 02:14:46 PST
Created attachment 175384 [details] Patch
Andrey Lushnikov
Comment 2 2012-11-21 02:43:37 PST
Created attachment 175390 [details] Patch
Andrey Adaikin
Comment 3 2012-11-21 04:16:53 PST
Comment on attachment 175390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:421 > + if (WebInspector.currentFocusElement().nodeName === "INPUT") call WebInspector.isBeingEdited(e.target) maybe?
Pavel Feldman
Comment 4 2012-11-21 04:28:14 PST
Comment on attachment 175390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:421 >> + if (WebInspector.currentFocusElement().nodeName === "INPUT") > > call WebInspector.isBeingEdited(e.target) maybe? You can edit text in non-INPUT fields as well. Imagine if we switch conditional breakpoints to the text area... You should check that e.target has no ancestors with className "webkit-line-decorations" instead.
Andrey Lushnikov
Comment 5 2012-11-21 08:39:56 PST
Created attachment 175454 [details] Patch
WebKit Review Bot
Comment 6 2012-11-21 09:35:02 PST
Comment on attachment 175454 [details] Patch Clearing flags on attachment: 175454 Committed r135412: <http://trac.webkit.org/changeset/135412>
WebKit Review Bot
Comment 7 2012-11-21 09:35:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.