RESOLVED FIXED 102899
[V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=102899
Summary [V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
Kentaro Hara
Reported 2012-11-21 01:29:35 PST
This is an incremental step to kill WorkerContextExecutionProxy. As commented by abarth in bug 97066, we move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer.
Attachments
Patch (15.28 KB, patch)
2012-11-21 01:32 PST, Kentaro Hara
no flags
patch for landing (15.28 KB, patch)
2012-11-21 02:40 PST, Kentaro Hara
no flags
Kentaro Hara
Comment 1 2012-11-21 01:32:57 PST
Adam Barth
Comment 2 2012-11-21 01:38:05 PST
Comment on attachment 175373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175373&action=review > Source/WebCore/bindings/v8/V8Initializer.h:31 > +#include <v8.h> > +#include <wtf/RefPtr.h> > +#include <wtf/text/WTFString.h> Why do you need these headers?
Kentaro Hara
Comment 3 2012-11-21 02:40:26 PST
Created attachment 175388 [details] patch for landing
Kentaro Hara
Comment 4 2012-11-21 02:41:01 PST
(In reply to comment #2) > > +#include <v8.h> > > +#include <wtf/RefPtr.h> > > +#include <wtf/text/WTFString.h> > > Why do you need these headers? Removed.
WebKit Review Bot
Comment 5 2012-11-21 03:25:59 PST
Comment on attachment 175388 [details] patch for landing Clearing flags on attachment: 175388 Committed r135377: <http://trac.webkit.org/changeset/135377>
WebKit Review Bot
Comment 6 2012-11-21 03:26:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.