RESOLVED FIXED 102898
css3/filters/effect-reference-ordering-hw.html started to crash
https://bugs.webkit.org/show_bug.cgi?id=102898
Summary css3/filters/effect-reference-ordering-hw.html started to crash
WebKit Review Bot
Reported 2012-11-21 01:25:07 PST
http://trac.webkit.org/changeset/135355 broke the build: css3/filters/effect-reference-ordering-hw.html started to crash (Requested by yurys on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r135355 (6.40 KB, patch)
2012-11-21 01:25 PST, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2012-11-21 01:25:47 PST
Created attachment 175370 [details] ROLLOUT of r135355 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Kent Tamura
Comment 2 2012-11-21 01:27:51 PST
I don't think r135355 can break it.
Yury Semikhatsky
Comment 3 2012-11-21 01:29:38 PST
The change made the test crash on Mac and Linux. Links to dashboard: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/2148 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/2026 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/1774 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/1679 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/1521 Stack trace: 00:42:20.090 8064 worker/3 css3/filters/effect-reference-ordering-hw.html crashed, (stderr lines): 00:42:20.091 8064 third_party/tcmalloc/chromium/src/free_list.cc:130] Memory corruption detected. 00:42:20.091 8064 Received signal 11 00:42:20.091 8064 base::debug::StackTrace::StackTrace() [0x83554a2] 00:42:20.091 8064 base::debug::(anonymous namespace)::StackDumpSignalHandler() [0x8355591] 00:42:20.091 8064 <unknown> [0xb7887400] 00:42:20.091 8064 tcmalloc::Log() [0x81f87ff] 00:42:20.091 8064 tcmalloc::FL_Next() [0x81f6a2c] 00:42:20.091 8064 tcmalloc::FL_Pop() [0x81f6bc1] 00:42:20.091 8064 malloc [0x9cbaafa] 00:42:20.091 8064 WTF::fastMalloc() [0x81212ee] 00:42:20.091 8064 WTF::Vector<>::reserveCapacity() [0x8a8433e] 00:42:20.091 8064 WTF::Vector<>::operator=() [0x8a92737] 00:42:20.091 8064 WTF::HashMap<>::inlineAdd() [0x8a93b17] 00:42:20.091 8064 WebCore::StyleResolver::addToMatchedPropertiesCache() [0x8a93eff] 00:42:20.091 8064 WebCore::StyleResolver::applyMatchedProperties() [0x8a9a7c0] 00:42:20.091 8064 WebCore::StyleResolver::styleForElement() [0x8a9e191] 00:42:20.091 8064 WebCore::Element::styleForRenderer() [0x82ec96f] 00:42:20.091 8064 WebCore::Element::recalcStyle() [0x82ecffc] 00:42:20.091 8064 WebCore::Element::recalcStyle() [0x82ed2a6] 00:42:20.092 8064 WebCore::Element::recalcStyle() [0x82ed2a6] 00:42:20.092 8064 WebCore::Document::recalcStyle() [0x82c7510] 00:42:20.092 8064 WebCore::Document::updateStyleIfNeeded() [0x82c785f] 00:42:20.092 8064 WebCore::Timer<>::fired() [0x82b8f4d] 00:42:20.092 8064 WebCore::ThreadTimers::sharedTimerFiredInternal() [0x887e961] 00:42:20.092 8064 WebCore::ThreadTimers::sharedTimerFired() [0x887ea1f] 00:42:20.092 8064 webkit_glue::WebKitPlatformSupportImpl::DoTimeout() [0x944b062] 00:42:20.092 8064 base::internal::Invoker<>::Run() [0x944b10e] 00:42:20.092 8064 base::Timer::RunScheduledTask() [0x96d0cb9] 00:42:20.092 8064 base::internal::Invoker<>::Run() [0x96d06ee] 00:42:20.092 8064 MessageLoop::RunTask() [0x836764d] 00:42:20.092 8064 MessageLoop::DeferOrRunPendingTask() [0x8367da2] 00:42:20.092 8064 MessageLoop::DoWork() [0x8368111] 00:42:20.092 8064 base::MessagePumpGlib::HandleDispatch() [0x8386298] 00:42:20.092 8064 (anonymous namespace)::WorkSourceDispatch() [0x83862d7] 00:42:20.092 8064 <unknown> [0xb75085e5] 00:42:20.092 8064 <unknown> [0xb750c2d8] 00:42:20.092 8064 <unknown> [0xb750c4b8] 00:42:20.092 8064 base::MessagePumpGlib::RunWithDispatcher() [0x8386769] 00:42:20.093 8064 base::MessagePumpGlib::Run() [0x83862fe] 00:42:20.093 8064 MessageLoop::RunInternal() [0x83627ce] 00:42:20.093 8064 base::RunLoop::Run() [0x8372349] 00:42:20.093 8064 MessageLoop::Run() [0x836149e] 00:42:20.093 8064 webkit_support::RunMessageLoop() [0x81dcc43] 00:42:20.093 8064 TestShell::waitTestFinished() [0x807c109] 00:42:20.093 8064 TestShell::runFileTest() [0x807a6e5] 00:42:20.093 8064 runTest() [0x805deee] 00:42:20.093 8064 main [0x805e4db] 00:42:20.093 8064 <unknown> [0xb6b93bd6] 00:42:20.093 8064 <unknown> [0x805cc01]
Yury Semikhatsky
Comment 4 2012-11-21 01:30:17 PST
(In reply to comment #2) > I don't think r135355 can break it. The results are pretty consistent, there is only one change in the range.
Kent Tamura
Comment 5 2012-11-21 01:32:55 PST
Yury Semikhatsky
Comment 6 2012-11-21 01:34:08 PST
(In reply to comment #5) > How about http://src.chromium.org/viewvc/chrome?view=rev&revision=168998 ? Yeah, it might be that one. Let me check it locally.
Yury Semikhatsky
Comment 8 2012-11-21 01:53:56 PST
(In reply to comment #6) > (In reply to comment #5) > > How about http://src.chromium.org/viewvc/chrome?view=rev&revision=168998 ? > > Yeah, it might be that one. Let me check it locally. tkent@, you were right, the test fails on the deps bot as well: http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/1782 and it clearly indicates that the problem is in http://src.chromium.org/viewvc/chrome?view=rev&revision=168998
Yury Semikhatsky
Comment 9 2012-11-21 02:42:31 PST
It crashed on Windows as well: http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7/builds/1043 I'm going to update expectations for the test at the moment and leave it to danakj@ to resolve the actual problem.
Yury Semikhatsky
Comment 10 2012-11-21 03:58:48 PST
Marked the test as crashing: http://trac.webkit.org/changeset/135380
Yury Semikhatsky
Comment 11 2012-11-21 07:19:56 PST
First attempt to mark the test wasn't successful, now do it in the right way: http://trac.webkit.org/changeset/135402
Dana Jansens
Comment 12 2012-11-21 17:11:24 PST
Looks like this is fixed now.
Dana Jansens
Comment 13 2012-11-21 17:22:24 PST
Removed Crash expectation here http://trac.webkit.org/changeset/135460
Note You need to log in before you can comment on or make changes to this bug.